Resolve finding (2) from #1529:

- AccountController: change wording from "Shared by me" to "Shared with others"
- ClientSharedByMeViewController:
	- change wording from "Shared by me" to "Shared with others"
	- remove duplicate section headers
- Localizable.xcstrings: change localization key from "Shared by me" to "Shared with others"

Author: felix-schwarz

ownCloud/Resources/Localizable.xcstrings

@@ -88492,24 +88492,24 @@
         }
       }
     },
-    "Shared by me" : {
+    "Shared with others" : {
       "localizations" : {
         "ar" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "ca" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "cs" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "de" : {
@@ -88521,13 +88521,13 @@
         "en" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "en-GB" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "es" : {
@@ -88539,43 +88539,43 @@
         "fr" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "it" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "ko" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "lo" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "mk" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "nb-NO" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "nn-NO" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "pt-BR" : {
@@ -88587,13 +88587,13 @@
         "pt-PT" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "ru" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "sq" : {
@@ -88605,25 +88605,25 @@
         "sv" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "th-TH" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "tr" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         },
         "zh-Hans" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Shared by me"
+            "value" : "Shared with others"
           }
         }
       }
@@ -108522,4 +108522,4 @@
     }
   },
   "version" : "1.0"
-}
+}

ownCloudAppShared/Client/Account/Controller/AccountController.swift

@@ -366,7 +366,7 @@ public class AccountController: NSObject, OCDataItem, OCDataItemVersioning, Acco
 				}
 
 				if specialItems[.sharedByMe] == nil {
-					specialItems[.sharedByMe] = CollectionSidebarAction(with: OCLocalizedString("Shared by me", nil), icon: OCSymbol.icon(forSymbolName: "arrowshape.turn.up.right"), identifier: specialItemsDataReferences[.sharedByMe], viewControllerProvider: { [weak self] context, action in
+					specialItems[.sharedByMe] = CollectionSidebarAction(with: OCLocalizedString("Shared with others", nil), icon: OCSymbol.icon(forSymbolName: "arrowshape.turn.up.right"), identifier: specialItemsDataReferences[.sharedByMe], viewControllerProvider: { [weak self] context, action in
 						return self?.provideViewController(for: .sharedByMe, in: context)
 					}, cacheViewControllers: false)
 				}

ownCloudAppShared/Client/View Controllers/ClientSharedByMeViewController.swift

@@ -36,7 +36,7 @@ class ClientSharedByMeViewController: CollectionViewController {
 		})
 		super.init(context: context, sections: nil, useStackViewRoot: true)
 		revoke(in: inContext, when: [ .connectionClosed ])
-		navigationItem.titleLabelText = (byMe && !byLink) ? OCLocalizedString("Shared by me", nil) : ((!byMe && byLink) ? OCLocalizedString("Shared by link", nil) : OCLocalizedString("Shared", nil))
+		navigationItem.titleLabelText = (byMe && !byLink) ? OCLocalizedString("Shared with others", nil) : ((!byMe && byLink) ? OCLocalizedString("Shared by link", nil) : OCLocalizedString("Shared", nil))
 	}
 
 	required public init?(coder: NSCoder) {
@@ -59,10 +59,6 @@ class ClientSharedByMeViewController: CollectionViewController {
 			section.hideIfEmptyDataSource = contentDataSource
 			section.hidden = true
 
-			section.boundarySupplementaryItems = [
-				.title(title, pinned: true)
-			]
-
 			return section
 		}
 
@@ -80,7 +76,7 @@ class ClientSharedByMeViewController: CollectionViewController {
 		var sectionsToAdd: [CollectionViewSection] = []
 
 		if hasByMeSection, let byMeDataSource = clientContext?.core?.sharedByMeGroupedDataSource {
-			sharedByMeSection = buildSection(identifier: "byMe", titled: OCLocalizedString("Shared by me", nil), contentDataSource: byMeDataSource)
+			sharedByMeSection = buildSection(identifier: "byMe", titled: OCLocalizedString("Shared with others", nil), contentDataSource: byMeDataSource)
 			sectionsToAdd.append(sharedByMeSection!)
 
 			addNoItemsCondition(imageName: "arrowshape.turn.up.right", title: OCLocalizedString("No items shared by you", nil), datasource: byMeDataSource)