OcCheckbox: add support for showing default values and clear buttons#1635
OcCheckbox: add support for showing default values and clear buttons#1635dschmidt wants to merge 6 commits into
Conversation
It's a bit more standard to not use v-model and split it into value binding and input event handling. Using a standard pattern makes it easier to reason about already and even more so when the clearButton is added in the next commit.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| created() { | ||
| this.setChecked(this.model) | ||
| showClearButton() { | ||
| return this.clearButtonEnabled && this.value !== null |
There was a problem hiding this comment.
this.disabled needs to be taken into account.
|
Hey, this is admittedly a hard one from a ux perspective, and I agree - the reset-x for a checkbox might feel odd. Requirements as I understood them:
I'm not aware of a common pattern, that meets both requirements for checkboxes. But maybe this ideas might help: Use OcSelectJust don't use checkboxes at all for this usecase. Utilise your OcSelect instead like this: Use text-buttonAs it might not be 100% expectable what the reset-x will do, a textbutton might make the action more predictable. But: Ideas 3-5 don't meet the 2nd requirement "Show if Default". Highlight changes with color: |
2 participants
Description
This PR adds support for showing default values and a clear button to
OcCheckbox.It's not beautiful (visually) by any means and the same UX problems as for #1634 apply here too.
Needs UX concept by @kulmann and @tbsbdr
Related Issue
(
@change,clearButtonEnabledanddefaultValue)Motivation and Context
See #1634
How Has This Been Tested?
Screenshots (if appropriate):
Nothing selected by user
Clicked once to switch value:
Clicked twice to explicitly set value:
Types of changes
Checklist:
Open tasks: