chore(deps-dev): bump vitest from 1.6.1 to 4.1.10#487
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
539112d to
c415eca
Compare
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 1.6.1 to 4.1.10. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.10/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 4.1.9 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
c415eca to
5e503cd
Compare
dj4oC
left a comment
There was a problem hiding this comment.
Bumps vitest — a major jump from ^1.5.0→^4.1.10 in five packages (web-app-ai-doc-summary, web-app-ai-folder-brief-sidebar, web-app-ai-image-alt-text-sidebar, web-app-ai-sensitive-data-scanner, web-app-file-comments), and a patch bump 4.1.7→4.1.10 elsewhere.
Findings
Stability (blocking, verified by actually running the tests). I checked out this PR branch, ran pnpm install --frozen-lockfile (succeeds, lockfile is consistent), then pnpm --filter <pkg> test:unit for each of the five packages that jumped vitest ^1.5.0→^4.1.10. All five fail identically before running a single test:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './module-runner' is not defined by "exports" in .../vite/package.json
These five packages still pin "vite": "^5.2.0" (resolves to vite@5.4.21), which predates the ./module-runner export subpath that vitest@4 requires at startup — so test:unit cannot even boot. By contrast, packages that were already on vitest@4.x and only took the 4.1.7→4.1.10 patch bump (e.g. web-app-ai-quick-draft-creator, pinned to vite: ^7.2.2) run fine (verified: 11/11 tests pass). This is a real, reproducible break in CI for those five packages, not a theoretical concern.
Security / Performance. No issues — pure dev-dependency version bump, nothing shipped to the production bundle.
Test coverage. N/A (dependency bump); the breakage above is exactly what pnpm test:unit in CI should catch.
Deployment topology check
N/A — dev tooling only, no runtime/deployment impact.
Verdict
Changes requested — either pin vite to a version that exports ./module-runner (vite ≥ 6, matching what the other already-v4 packages use) in the same five package.jsons, or hold vitest back to a version compatible with vite@5.2 for those packages, before merging.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
dj4oC
left a comment
There was a problem hiding this comment.
Investigated the red check:types job (failing since 2026-07-07, not yet reviewed by this bot).
Findings
- Stability (blocking, pre-existing latent bug unmasked by this bump, not introduced by it):
vitest1.6.1→4.1.10 pulls in an updated type-checking chain that now surfaces a pre-existing gap inpackages/web-app-ai-folder-brief-sidebar/tests/unit/useFolderBrief.spec.ts:68and:178— the mockResourceobjects are missing the requiredspaceIdfield:This is exactly theerror TS2741: Property 'spaceId' is missing in type '{...}' but required in type 'Resource'.Resource.spaceId requiredrule from this repo's CLAUDE.md — the test fixtures never satisfied it and only failed to type-check once the dependency graph re-resolved. Fix: addspaceId: '<test-space-id>'to both mockResource/Resource[]literals in that spec file. - No other packages affected; this is an isolated, mechanical one-line-per-mock fix, not a vitest 4.x API break.
Test coverage
n/a — dependency bump; the fix is to an existing test's fixture data, not new coverage.
Verdict
Changes requested (blocked on CI) — add spaceId to the two mock Resource fixtures in useFolderBrief.spec.ts before merge.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
Bumps vitest from 1.6.1 to 4.1.10.
Release notes
Sourced from vitest's releases.
... (truncated)
Commits
db616d2chore: release v4.1.10 (#10718)bae52b5fix(vm): fix external module resolve error with deps optimizer query for enco...a7a61e7chore: release v4.1.9 (#10598)934b0f5fix(pool): prevent test run hang on worker crash (#10543) [backport to v4] (#...7fb2965fix(browser): wait for orchestrator readiness before resolving browser sessio...a518019fix: fiximportOriginalwith optimizer and query import [backport to v4] (#...e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...a09d472chore: release v4.1.7a8fd24cchore: release v4.1.6Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for vitest since your current version.