tests: reduce OCM tests flakiness

Author: mklos-kw

.github/workflows/test.yml

@@ -181,6 +181,14 @@ jobs:
           KEYCLOAK_HOST: ${{ matrix.suites.keycloak && 'localhost:8443' || '' }}
         run: cd ${{ github.workspace }}/tests/e2e && bash run-e2e.sh --type playwright
 
+      - name: Dump oCIS logs on failure
+        if: failure()
+        run: |
+          echo "=== oCIS LOCAL: relevant log lines ==="
+          grep -i "ocm\|provider\|invite\|federation\|error\|ERR\|permissions\|drives.*items\|Federated" /tmp/ocis-ocis.log 2>/dev/null | tail -300 || echo "(no log file)"
+          echo "=== oCIS FEDERATED: relevant log lines ==="
+          grep -i "ocm\|provider\|invite\|federation\|error\|ERR\|permissions\|drives.*items\|Federated" /tmp/ocis-ocis-federated.log 2>/dev/null | tail -300 || echo "(no log file)"
+
       - name: Upload tracing result
         if: failure()
         uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
@@ -196,3 +204,14 @@ jobs:
           name: playwright-a11y-result-${{ strategy.job-index }}-${{ github.run_attempt }}
           path: ${{ github.workspace }}/reports/e2e/a11y-report.json
           retention-days: 7
+
+  check-tests-passed:
+    needs: [e2e-playwright]
+    runs-on: ubuntu-latest
+    if: always()
+    steps:
+      - name: Check all test jobs passed
+        run: |
+          if [[ "${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}" == "true" ]]; then
+            exit 1
+          fi

tests/actions/setup-services.sh

@@ -337,4 +337,31 @@ fi
 
 if $FEDERATION_ENABLED; then
   setup_ocis "ocis-federated" 10200
+  wait_for_service "https://localhost:10200/.well-known/openid-configuration" "ocis-federated"
+
+  echo "=== Diagnostic: Graph role definitions on LOCAL (:9200) ==="
+  curl -kfsSL -u admin:admin "https://localhost:9200/graph/v1beta1/roleManagement/permissions/roleDefinitions" | python3 -c "import sys,json; roles=json.load(sys.stdin); [print(r['id'], r['displayName']) for r in roles]" || echo "WARNING: Graph role definitions failed on LOCAL"
+
+  echo "=== Diagnostic: listPermissions with Federated filter (admin folder) ==="
+  ADMIN_HOME_ID=$(curl -kfsSL -u admin:admin "https://localhost:9200/graph/v1.0/me/drives" | python3 -c "import sys,json; d=json.load(sys.stdin); print([x for x in d['value'] if x['driveType']=='personal'][0]['id'])" 2>/dev/null || echo "")
+  if [ -n "$ADMIN_HOME_ID" ]; then
+    echo "  Drive ID: $ADMIN_HOME_ID"
+    # Create a test folder to get a valid non-root item ID (space root has no federated roles by design)
+    curl -kfsSL -u admin:admin -X MKCOL \
+      "https://localhost:9200/remote.php/dav/spaces/$ADMIN_HOME_ID/federated-role-test/" > /dev/null 2>&1 || true
+    FOLDER_ITEM_ID=$(curl -kfsSL -u admin:admin \
+      "https://localhost:9200/graph/v1.0/drives/$ADMIN_HOME_ID/items/root:/federated-role-test:/" \
+      | python3 -c "import sys,json; d=json.load(sys.stdin); print(d.get('id',''))" 2>/dev/null || echo "")
+    if [ -n "$FOLDER_ITEM_ID" ]; then
+      echo "  Folder item ID: $FOLDER_ITEM_ID"
+      curl -ksSL -u admin:admin \
+        "https://localhost:9200/graph/v1beta1/drives/$ADMIN_HOME_ID/items/$FOLDER_ITEM_ID/permissions?\$filter=@libre.graph.permissions.roles.allowedValues/rolePermissions/any(p:contains(p/condition,%20'@Subject.UserType%3D%3D%22Federated%22'))&\$select=@libre.graph.permissions.roles.allowedValues" \
+        | python3 -c "import sys,json; d=json.load(sys.stdin); roles=d.get('@libre.graph.permissions.roles.allowedValues',[]); [print(r['id'], r.get('displayName','?')) for r in roles] or print('  (empty roles list)')" \
+        2>/dev/null || echo "WARNING: listPermissions with Federated filter failed"
+    else
+      echo "WARNING: Could not get folder item ID"
+    fi
+  else
+    echo "WARNING: Could not get admin home drive ID"
+  fi
 fi

tests/drone/providers.json

@@ -20,5 +20,27 @@
         "host": ".*:9200"
       }
     ]
+  },
+  {
+    "name": "ocis-federated",
+    "full_name": "ocis federated server",
+    "organization": "ownCloud",
+    "domain": ".*:10200",
+    "homepage": "https://owncloud.com",
+    "services": [
+      {
+        "endpoint": {
+          "type": {
+            "name": "OCM",
+            "description": "ownCloud Open Cloud Mesh API"
+          },
+          "name": "ownCloud - OCM API",
+          "path": "https://.*:10200/ocm/",
+          "is_monitored": true
+        },
+        "api_version": "0.0.1",
+        "host": ".*:10200"
+      }
+    ]
   }
 ]

tests/e2e/support/objects/app-files/search/actions.ts

@@ -129,7 +129,15 @@ export const toggleSearchTitleOnly = async ({
 }): Promise<void> => {
   const selector =
     enableOrDisable === 'enable' ? enableSearchTitleOnlySelector : disableSearchTitleOnlySelector
-  await page.locator(selector).click()
+  await Promise.all([
+    page.waitForResponse(
+      (resp) =>
+        resp.url().includes('/dav/spaces') &&
+        resp.status() === 207 &&
+        resp.request().method() === 'REPORT'
+    ),
+    page.locator(selector).click()
+  ])
   await objects.a11y.Accessibility.assertNoSevereA11yViolations(
     page,
     ['files'],

tests/e2e/support/objects/app-files/share/actions.ts

@@ -101,15 +101,39 @@ export const createShare = async (args: createShareArgs): Promise<void> => {
   }
   const federatedShare = recipients[0].shareType
   if (federatedShare) {
-    await Promise.all([
-      locatorUtils.waitForEvent(page.locator(invitePanel), 'transitionend'),
-      page.locator(userTypeFilter).click()
-    ])
+    // --- WHY THIS WORKAROUND EXISTS ---
+    // The "External users" filter chip (OcFilterChip → OcDrop → Tippy.js) teleports its
+    // dropdown content to document.body, outside the Vue component tree. Tippy's own
+    // `close-on-click` handler fires on the toggle BEFORE the bubbled event reaches Vue's
+    // @click="selectShareRoleType(option)" in InviteCollaboratorForm.vue.
+    // With the original page.locator(userTypeFilter).click(), isExternalShareRoleType stayed
+    // false: the invite input searched all users (not Federated), Brian Murphy was not found.
+    //
+    // Fix: open the dropdown via Tippy's JS API (btn._tippy.show()) — bypasses Playwright's
+    // synthetic event path. Then fire the item click via dispatchEvent({bubbles:true})
+    // directly on the DOM node so it reaches Vue's handler before Tippy can intercept.
+    //
+    await page.evaluate(() => {
+      const btn = document.querySelector(
+        '.invite-form-share-role-type .oc-filter-chip-button'
+      ) as any
+      btn?._tippy?.show()
+    })
+    await page.locator(userTypeSelector).filter({ hasText: federatedShare }).waitFor()
     await objects.a11y.Accessibility.assertNoSevereA11yViolations(page, ['tippyBox'], 'app sidebar')
-    await page.locator(userTypeSelector).filter({ hasText: federatedShare }).click()
+    // Use JS dispatchEvent — Playwright .click() on teleported Tippy content may not reach Vue handlers
+    await page.evaluate((shareType) => {
+      const items = Array.from(document.querySelectorAll('.invite-form-share-role-type-item'))
+      const target = items.find((el) =>
+        el.textContent?.toLowerCase().includes(shareType.toLowerCase())
+      ) as HTMLElement
+      target?.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }))
+    }, federatedShare)
+    // Small wait for Vue reactivity to update
+    await page.waitForTimeout(200)
   }
-  await Collaborator.inviteCollaborators({ page, collaborators: recipients })
 
+  await Collaborator.inviteCollaborators({ page, collaborators: recipients })
   await sidebar.close({ page })
 }
 

tests/e2e/support/objects/app-files/share/collaborator.ts

@@ -132,7 +132,18 @@ export default class Collaborator {
         })
       )
     }
-    await Promise.all([...checkResponses, page.locator(Collaborator.sendInvitationButton).click()])
+    // --- WHY THIS WORKAROUND EXISTS ---
+    // The Share button (#new-collaborators-form-create-button) sits inside vue-select's
+    // vs__actions div. Playwright's page.locator(...).click() did not reach Vue's
+    // @click="share" handler — POST /graph/.../invite was never made, waitForResponse
+    // timed out after 30 s. dispatchEvent fires the click directly on the DOM node.
+    await Promise.all([
+      ...checkResponses,
+      page.evaluate(() => {
+        const btn = document.querySelector('#new-collaborators-form-create-button') as HTMLElement
+        btn?.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }))
+      })
+    ])
   }
 
   static async inviteCollaborators(args: InviteCollaboratorsArgs): Promise<void> {
@@ -161,9 +172,38 @@ export default class Collaborator {
       dropdownSelector = Collaborator.newCollaboratorRoleDropdown
       itemSelector = Collaborator.collaboratorRoleButton
     }
-    await page.locator(dropdownSelector).click()
+    // --- WHY THIS WORKAROUND EXISTS ---
+    // The role dropdown (#files-collaborators-role-button-new) is a Tippy toggle inside
+    // vue-select's vs__actions container. Same mechanism as the filter chip in actions.ts:
+    // Playwright .click() is intercepted by Tippy's close-on-click before Vue's
+    // @option-change="collaboratorRoleChanged" fires — the role never changes, and the test
+    // timed out waiting for //button[contains(@id,"fb6c3e19-...")] (the selected-role indicator).
+    //
+    // Fix: open via _tippy.show(), then fire via dispatchEvent on the role button.
+    // Note: itemSelector is an XPath expression like '//button[contains(@id,"fb6c3e19-...")]'.
+    // document.querySelector() rejects XPath syntax (throws DOMException) —
+    // document.evaluate() is required to resolve XPath nodes.
+    const toggleId = await page.locator(dropdownSelector).getAttribute('id')
+    await page.evaluate((id) => {
+      const btn = id
+        ? document.getElementById(id)
+        : (document.querySelector('[id^="files-collaborators-role-button"]') as any)
+      btn?._tippy?.show()
+    }, toggleId)
     await objects.a11y.Accessibility.assertNoSevereA11yViolations(page, ['tippyBox'], 'tippy box')
-    await page.locator(util.format(itemSelector, role)).click()
+    // dispatchEvent since Tippy close-on-click intercepts .click() before Vue handler fires
+    const roleSelector = util.format(itemSelector, role)
+    await page.locator(roleSelector).waitFor()
+    await page.evaluate((xpathSelector) => {
+      const btn = document.evaluate(
+        xpathSelector,
+        document,
+        null,
+        XPathResult.FIRST_ORDERED_NODE_TYPE,
+        null
+      ).singleNodeValue as HTMLElement
+      btn?.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }))
+    }, roleSelector)
   }
 
   static async changeCollaboratorRole(args: CollaboratorArgs): Promise<void> {