Skip to content

[full-ci][tests-only] test: convert kindergarten.feature test to playwright#13536

Open
nirajacharya2 wants to merge 2 commits intomasterfrom
kindergarten-2-pw
Open

[full-ci][tests-only] test: convert kindergarten.feature test to playwright#13536
nirajacharya2 wants to merge 2 commits intomasterfrom
kindergarten-2-pw

Conversation

@nirajacharya2
Copy link
Copy Markdown
Contributor

@nirajacharya2 nirajacharya2 commented Jan 26, 2026

Description

convert kindergarten.feature test to playwright test

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@nirajacharya2 nirajacharya2 self-assigned this Jan 26, 2026
@nirajacharya2 nirajacharya2 marked this pull request as draft January 26, 2026 10:01
@nirajacharya2 nirajacharya2 force-pushed the kindergarten-2-pw branch 13 times, most recently from 880a06a to e08c602 Compare March 6, 2026 08:13
@nirajacharya2 nirajacharya2 marked this pull request as ready for review March 6, 2026 08:51
Comment thread tests/e2e/config.js
// playwright
slowMo: parseInt(process.env.SLOW_MO) || 0,
timeout: parseInt(process.env.TIMEOUT) || 120,
timeout: parseInt(process.env.TIMEOUT) || 180,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to change it because test was taking too long.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use TIMEOUT env for CI

@nirajacharya2 nirajacharya2 force-pushed the kindergarten-2-pw branch 2 times, most recently from 938eada to b1f75ff Compare March 13, 2026 06:05
@sonarqubecloud
Copy link
Copy Markdown

Comment thread tests/e2e-playwright/specs/journeys/kindergarten.spec.ts Outdated
Comment thread tests/e2e-playwright/specs/app-provider/officeSuites.spec.ts Outdated
Comment thread .drone.star
Comment thread tests/e2e-playwright/specs/journeys/kindergarten.spec.ts Outdated
@nirajacharya2 nirajacharya2 force-pushed the kindergarten-2-pw branch 2 times, most recently from fb929fd to b32ac91 Compare April 28, 2026 08:47
@nirajacharya2 nirajacharya2 force-pushed the kindergarten-2-pw branch 2 times, most recently from 35dc684 to 47fc1df Compare April 28, 2026 08:55
Comment thread .github/workflows/test.yml Outdated
@sonarqubecloud
Copy link
Copy Markdown

Comment on lines 103 to +104
feature_files: specs/admin-settings/spaces.spec.ts
test_suites: journeys
Copy link
Copy Markdown
Member

@saw-jan saw-jan Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think providing both features and suites will work. need to be one of them

Suggested change
feature_files: specs/admin-settings/spaces.spec.ts
test_suites: journeys
feature_files: specs/admin-settings/spaces.spec.ts,specs/journeys

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants