Skip to content

Commit b95bb14

Browse files
Copilotowndev
andcommitted
Fix code review comments: consistent None handling and updated valve description
Co-authored-by: owndev <69784886+owndev@users.noreply.github.com>
1 parent 54ce441 commit b95bb14

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

pipelines/google/google_gemini.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,8 @@ class Valves(BaseModel):
209209
)
210210
DEFAULT_SYSTEM_PROMPT: str = Field(
211211
default=os.getenv("GOOGLE_DEFAULT_SYSTEM_PROMPT", ""),
212-
description="Default system prompt applied to all chats. If a user-defined system prompt exists, "
213-
"this is prepended to it. Leave empty to disable.",
212+
description="Default system prompt applied to all chats. Combined with per-user personalization "
213+
"and chat-level prompts in a hierarchy: default → per-user → per-chat. Leave empty to disable.",
214214
)
215215

216216
# Image Processing Configuration
@@ -329,9 +329,9 @@ def _combine_system_prompts(
329329
Returns:
330330
Combined system prompt or None if none are set
331331
"""
332-
default_prompt = self.valves.DEFAULT_SYSTEM_PROMPT.strip()
333-
user_personalization = self._get_user_personalization_prompt() or ""
334-
chat_prompt = chat_system_prompt.strip() if chat_system_prompt else ""
332+
default_prompt = self.valves.DEFAULT_SYSTEM_PROMPT.strip() or None
333+
user_personalization = self._get_user_personalization_prompt()
334+
chat_prompt = chat_system_prompt.strip() if chat_system_prompt else None
335335

336336
prompts = [p for p in [default_prompt, user_personalization, chat_prompt] if p]
337337

0 commit comments

Comments
 (0)