UI(vue) + extras: fix bugs/spelling and standardize (apache#12073)

Author: jbampton

.github/linters/codespell.txt

@@ -255,7 +255,6 @@ ingore
 initalize
 initator
 inspite
-instace
 instal
 instnace
 intefaces
@@ -376,7 +375,6 @@ renabling
 reponse
 reqest
 reqiured
-requried
 reserv
 reserverd
 reseted

plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs

@@ -26,7 +26,7 @@
 // C# versions of certain CloudStack types to simplify JSON serialisation.
 // Limit to the number of types, because they are written and maintained manually.
 // JsonProperty used to identify property name when serialised, which allows
-// later adoption of C# naming conventions if requried.
+// later adoption of C# naming conventions if required.
 namespace HypervResource
 {
     public class PrimaryDataStoreTO

server/src/test/java/com/cloud/api/ApiResponseHelperTest.java

@@ -458,7 +458,7 @@ public void testCreateTrafficTypeResponse() {
         }
     }
 
-    private UnmanagedInstanceTO getUnmanagedInstaceForTests() {
+    private UnmanagedInstanceTO getUnmanagedInstanceForTests() {
         UnmanagedInstanceTO instance = Mockito.mock(UnmanagedInstanceTO.class);
         Mockito.when(instance.getPowerState()).thenReturn(UnmanagedInstanceTO.PowerState.PowerOff);
         Mockito.when(instance.getClusterName()).thenReturn("CL1");
@@ -477,7 +477,7 @@ private UnmanagedInstanceTO getUnmanagedInstaceForTests() {
 
     @Test
     public void testCreateUnmanagedInstanceResponseVmwareDcVms() {
-        UnmanagedInstanceTO instance = getUnmanagedInstaceForTests();
+        UnmanagedInstanceTO instance = getUnmanagedInstanceForTests();
         UnmanagedInstanceResponse response = apiResponseHelper.createUnmanagedInstanceResponse(instance, null, null);
         Assert.assertEquals(1, response.getDisks().size());
         Assert.assertEquals(1, response.getNics().size());

test/integration/component/test_netscaler_nw_off.py

@@ -802,7 +802,7 @@ def test_02_multiple_netscaler_capacilty(self):
 
         # Validate the following
         # 1. Add another netscaler device and spawn a new VM again
-        # 2. VM deployement should be successful
+        # 2. VM deployment should be successful
 
         self.debug("Adding another netscaler device: %s" %
                                     self.services["netscaler_2"]["ipaddress"])
@@ -1672,7 +1672,7 @@ def test_shared_to_dedicated_upgrade(self):
         #   LB rules
         # 5. Deploy instance with dedicated network offering in account 3.
         #   Create Lb rules.
-        # 6. Configure another instace of netscaler in dedicated mode
+        # 6. Configure another instance of netscaler in dedicated mode
         # 7. upgrade networkj for user 1 to dedicated network offering.
         #    Create LB rules. LB rule creation should be successful
 
@@ -2063,7 +2063,7 @@ def test_shared_to_dedicated_upgrade(self):
         #   LB rules
         # 5. Deploy instance with dedicated network offering in account 3.
         #   Create Lb rules.
-        # 6. Configure another instace of netscaler in dedicated mode
+        # 6. Configure another instance of netscaler in dedicated mode
         # 7. upgrade networkj for user 1 to dedicated network offering.
         #    Create LB rules. LB rule creation should be successful
 

test/integration/component/test_vpc_vm_life_cycle.py

@@ -1274,7 +1274,7 @@ def test_02_deploy_vm_vpcvr_stopped(self):
         except Exception as e:
             self.fail("Failed to deploy the virtual instance: %s" % e)
 
-        self.debug("Verify the deployment of virtual instace")
+        self.debug("Verify the deployment of virtual instance")
         vms = VirtualMachine.list(
                                   self.apiclient,
                                   id=vm.id,

ui/src/components/view/DedicateDomain.vue

@@ -59,7 +59,7 @@ export default {
   props: {
     error: {
       type: Boolean,
-      requried: true
+      required: true
     }
   },
   data () {

ui/src/components/view/DeployVMFromBackup.vue

@@ -1589,7 +1589,7 @@ export default {
       })
       this.fetchBootTypes()
       this.fetchBootModes()
-      this.fetchInstaceGroups()
+      this.fetchInstanceGroups()
       this.fetchIoPolicyTypes()
       nextTick().then(() => {
         ['name', 'keyboard', 'boottype', 'bootmode', 'iothreadsenabled', 'iodriverpolicy', 'nicmultiqueuenumber', 'nicpackedvirtqueues'].forEach(this.fillValue)
@@ -1640,7 +1640,7 @@ export default {
         { id: 'storage_specific', description: 'storage_specific' }
       ]
     },
-    fetchInstaceGroups () {
+    fetchInstanceGroups () {
       this.options.instanceGroups = []
       getAPI('listInstanceGroups', {
         account: this.$store.getters.project?.id ? null : this.$store.getters.userInfo.account,
@@ -2469,12 +2469,12 @@ export default {
           configuration.cpunumber = 0
           configuration.cpuspeed = 0
           configuration.memory = 0
-          for (var harwareItem of configuration.hardwareItems) {
-            if (harwareItem.resourceType === 'Processor') {
-              configuration.cpunumber = harwareItem.virtualQuantity
-              configuration.cpuspeed = harwareItem.reservation
-            } else if (harwareItem.resourceType === 'Memory') {
-              configuration.memory = harwareItem.virtualQuantity
+          for (var hardwareItem of configuration.hardwareItems) {
+            if (hardwareItem.resourceType === 'Processor') {
+              configuration.cpunumber = hardwareItem.virtualQuantity
+              configuration.cpuspeed = hardwareItem.reservation
+            } else if (hardwareItem.resourceType === 'Memory') {
+              configuration.memory = hardwareItem.virtualQuantity
             }
           }
           configurations.push(configuration)

ui/src/components/view/ResourceCountUsage.vue

@@ -40,7 +40,7 @@
               v-if="taggedUsage[item]"
               class="list-item__collapse"
               @change="handleCollapseChange(item)">
-            <a-collapse-panel key="1" :header="collpaseActive[item] ? $t('label.tagged.limits') : $t('label.tagged.limits') + ' - ' + this.tagData[item].tagsasstring">
+            <a-collapse-panel key="1" :header="collapseActive[item] ? $t('label.tagged.limits') : $t('label.tagged.limits') + ' - ' + this.tagData[item].tagsasstring">
               <a-list
                 size="small"
                 :loading="loading"
@@ -96,7 +96,7 @@ export default {
       ],
       taggedUsage: {},
       tagData: {},
-      collpaseActive: {}
+      collapseActive: {}
     }
   },
   created () {
@@ -168,11 +168,11 @@ export default {
       }
     },
     handleCollapseChange (type) {
-      if (this.collpaseActive[type]) {
-        this.collpaseActive[type] = null
+      if (this.collapseActive[type]) {
+        this.collapseActive[type] = null
         return
       }
-      this.collpaseActive[type] = true
+      this.collapseActive[type] = true
     }
   }
 }

ui/src/components/view/ResourceLimitTab.vue

@@ -43,7 +43,7 @@
             v-if="item.taggedresource && item.taggedresource.length > 0"
             class="tagged-limit-collapse"
             @change="handleCollapseChange(item.resourcetypename)">
-          <a-collapse-panel key="1" :header="collpaseActive[item.resourcetypename] ? $t('label.tagged.limits') : $t('label.tagged.limits') + ' - ' + item.tagsasstring">
+          <a-collapse-panel key="1" :header="collapseActive[item.resourcetypename] ? $t('label.tagged.limits') : $t('label.tagged.limits') + ' - ' + item.tagsasstring">
             <div v-for="(subItem, subItemIndex) in item.taggedresource" :key="subItemIndex">
               <a-form-item
                 :v-bind="subItem.resourcetypename"
@@ -94,7 +94,7 @@ export default {
     return {
       formLoading: false,
       dataResource: [],
-      collpaseActive: {},
+      collapseActive: {},
       resourceTypeIdNames: {}
     }
   },
@@ -259,11 +259,11 @@ export default {
       })
     },
     handleCollapseChange (type) {
-      if (this.collpaseActive[type]) {
-        this.collpaseActive[type] = null
+      if (this.collapseActive[type]) {
+        this.collapseActive[type] = null
         return
       }
-      this.collpaseActive[type] = true
+      this.collapseActive[type] = true
     }
   }
 }

ui/src/components/view/TestWebhookDeliveryView.vue

@@ -126,7 +126,7 @@ export default {
       collapseKey: undefined,
       loading: false,
       testDeliveryInterval: null,
-      testDeliveryIntervalCouter: 0
+      testDeliveryIntervalCounter: 0
     }
   },
   beforeCreate () {
@@ -154,8 +154,8 @@ export default {
       return (duration > 0 ? duration / 1000.0 : 0) + ''
     },
     computedOverlayStyle () {
-      var opacity = this.testDeliveryIntervalCouter <= 10.0 ? 0 : 0.3
-      var width = this.testDeliveryIntervalCouter
+      var opacity = this.testDeliveryIntervalCounter <= 10.0 ? 0 : 0.3
+      var width = this.testDeliveryIntervalCounter
       return 'opacity: ' + opacity + '; width: ' + width + '%;'
     }
   },
@@ -168,7 +168,7 @@ export default {
       if (this.testDeliveryInterval) {
         clearInterval(this.testDeliveryInterval)
       }
-      this.testDeliveryIntervalCouter = 0
+      this.testDeliveryIntervalCounter = 0
     },
     testWebhookDelivery () {
       this.resetTestDeliveryInterval()
@@ -223,8 +223,8 @@ export default {
           this.resetTestDeliveryInterval()
           return
         }
-        this.testDeliveryIntervalCouter = this.testDeliveryIntervalCouter + 1
-        if (this.testDeliveryIntervalCouter >= 100) {
+        this.testDeliveryIntervalCounter = this.testDeliveryIntervalCounter + 1
+        if (this.testDeliveryIntervalCounter >= 100) {
           this.executeTestWebhookDeliveryOrReset()
         }
       }, this.timedDeliveryWait / 100)