feat(formatter): support ignore ranges#22181
Closed
mmkal wants to merge 2 commits into
Closed
Conversation
# Conflicts: # crates/oxc_formatter/src/print/program.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds range ignore support to
oxc_formatterfor JavaScript and TypeScript formatter paths.Supported markers:
When a range marker appears before a statement or class element, the formatter emits source text through the matching
*-ignore-endcomment unchanged, marks comments inside the range as printed, skips AST nodes covered by the range, and resumes normal formatting afterward.This supports both native
oxfmt-ignore-start/oxfmt-ignore-endand Prettier-compatibleprettier-ignore-start/prettier-ignore-endmarkers. It implements the range-ignore portion of @BlankParticle's feature request in #22182 and is related to prettier/prettier#5287.I also merged current upstream
maininto this branch so the draft PR is no longer based on the stale branch revision.Tests
cargo fmt -p oxc_formattercargo test -p oxc_formattercargo check -p oxfmt --no-default-featuresAI Assistance
Prepared with AI assistance. The contributor is responsible for reviewing and validating the changes before merge.