test(no-floating-promises): re-enable node test allowlist case#978
Draft
camc314 wants to merge 1 commit into
Draft
Conversation
camc314
force-pushed
the
codex/no-floating-promises-node-test-allowlist
branch
from
0677cdc to
2edb659
Compare
camc314
force-pushed
the
codex/no-floating-promises-recursive-type-args
branch
from
a7eff35 to
22df9f9
Compare
camc314
force-pushed
the
codex/no-floating-promises-node-test-allowlist
branch
from
2edb659 to
87a1bd1
Compare
camc314
force-pushed
the
codex/no-floating-promises-recursive-type-args
branch
from
22df9f9 to
4ec1443
Compare
camc314
force-pushed
the
codex/no-floating-promises-node-test-allowlist
branch
from
87a1bd1 to
32905c6
Compare
camc314
force-pushed
the
codex/no-floating-promises-recursive-type-args
branch
from
4ec1443 to
44d3ec7
Compare
camc314
force-pushed
the
codex/no-floating-promises-node-test-allowlist
branch
from
32905c6 to
4fbfbcf
Compare
camc314
force-pushed
the
codex/no-floating-promises-recursive-type-args
branch
from
44d3ec7 to
3c6aec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #977, which is stacked on #976 and #975.
This re-enables the
allowForKnownSafeCallsnode:testpackage case. On top of the preceding stack entries, the case passes without additional implementation changes.Validation:
go test ./internal/rules/no_floating_promises/...