Skip to content

Commit 2ef0688

Browse files
committed
merge main
2 parents 4d4e03f + 59f225e commit 2ef0688

13 files changed

Lines changed: 25 additions & 86 deletions

File tree

.github/renovate.json5

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,4 @@
11
{
22
$schema: 'https://docs.renovatebot.com/renovate-schema.json',
3-
extends: ['config:base'],
4-
enabledManagers: ['npm'],
5-
packageRules: [
6-
// Disable all npm dependency updates by default
7-
{
8-
managers: ['npm'],
9-
depTypeList: ['dependencies', 'devDependencies', 'peerDependencies'],
10-
packagePatterns: ['*'],
11-
enabled: false,
12-
},
13-
// Disable all engine updates by default
14-
{
15-
managers: ['npm'],
16-
depTypeList: ['engines'],
17-
packagePatterns: ['*'],
18-
enabled: false,
19-
},
20-
// Packages to auto update and auto merge if CI passes
21-
{
22-
managers: ['npm'],
23-
packageNames: ['typescript'],
24-
enabled: true,
25-
},
26-
// Open PRs for any oxide packages
27-
{
28-
managers: ['npm'],
29-
packagePatterns: ['@oxide/*'],
30-
enabled: true,
31-
},
32-
],
3+
enabled: false,
334
}

app/components/AttachEphemeralIpModal.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@ export const AttachEphemeralIpModal = ({
6565
addToast(<>IP <HL>{ephemeralIp.ip}</HL> attached</>)
6666
onDismiss()
6767
},
68-
onError: (err) => {
69-
addToast({ title: 'Error', content: err.message, variant: 'error' })
70-
},
7168
})
7269

7370
const form = useForm({ defaultValues: { pool: defaultPool } })
@@ -96,6 +93,9 @@ export const AttachEphemeralIpModal = ({
9693
noItemsPlaceholder="No pools available"
9794
/>
9895
</form>
96+
{instanceEphemeralIpAttach.error && (
97+
<p className="text-error mt-4">{instanceEphemeralIpAttach.error.message}</p>
98+
)}
9999
</Modal.Section>
100100
</Modal.Body>
101101
<Modal.Footer

app/components/AttachFloatingIpModal.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@ export const AttachFloatingIpModal = ({
8585
addToast(<>IP <HL>{floatingIp.name}</HL> attached</>)
8686
onDismiss()
8787
},
88-
onError: (err) => {
89-
addToast({ title: 'Error', content: err.message, variant: 'error' })
90-
},
9188
})
9289
const form = useForm({ defaultValues: { floatingIp: '' } })
9390
const floatingIp = form.watch('floatingIp')

app/components/Terminal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ function getTheme(): ITerminalOptions['theme'] {
3838
brightCyan: style.getPropertyValue('--content-accent'),
3939
magenta: style.getPropertyValue('--content-accent-alt-secondary'),
4040
brightMagenta: style.getPropertyValue('--content-accent-alt'),
41+
selectionBackground: style.getPropertyValue('--surface-accent'),
4142
cursor: style.getPropertyValue('--content-default'),
4243
cursorAccent: style.getPropertyValue('--surface-default'),
4344
}

app/pages/project/instances/InstancePage.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,6 @@ export function ResizeInstanceModal({
301301
: undefined, // Only link to the instance if we're not already on that page
302302
})
303303
},
304-
onError: (err) => {
305-
addToast({ title: 'Error', content: err.message, variant: 'error' })
306-
},
307304
})
308305

309306
const form = useForm({

app/ui/lib/ActionMenu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,11 @@ export function ActionMenu(props: ActionMenuProps) {
109109
e.preventDefault()
110110
onDismiss()
111111
}
112-
} else if (e.key === KEYS.down || (e.ctrlKey && e.key === 'n')) {
112+
} else if (e.key === KEYS.down) {
113113
e.preventDefault()
114114
const newIdx = selectedIdx === lastIdx ? 0 : selectedIdx + 1
115115
setSelectedIdx(newIdx)
116-
} else if (e.key === KEYS.up || (e.ctrlKey && e.key === 'p')) {
116+
} else if (e.key === KEYS.up) {
117117
e.preventDefault()
118118
const newIdx = selectedIdx === 0 ? lastIdx : selectedIdx - 1
119119
setSelectedIdx(newIdx)

app/ui/lib/Combobox.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ export const Combobox = ({
252252
{items.length > 0 && (
253253
<ComboboxButton
254254
className={cn(
255-
'border-secondary my-1.5 flex items-center border-l px-3',
255+
'relative flex items-center px-3 before:absolute before:inset-y-1.5 before:left-0 before:w-px before:content-[""] before:bg-(--stroke-secondary)',
256256
disabled ? 'bg-disabled cursor-not-allowed' : 'bg-default'
257257
)}
258258
aria-hidden

app/ui/lib/Progress.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const Progress = (props: ProgressProps) => (
2525
{...ariaLabel(props)}
2626
>
2727
<div
28-
className="bg-accent h-1 rounded-[1px]"
28+
className="bg-accent-inverse h-1 rounded-[1px]"
2929
style={{
3030
width: `${props.value}%`,
3131
transition:

app/ui/styles/index.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@
7575

7676
::-moz-selection {
7777
/* Code for Firefox */
78-
@apply text-accent bg-accent;
78+
@apply bg-accent-inverse/30;
7979
}
8080

8181
::selection {
82-
@apply text-accent bg-accent;
82+
@apply bg-accent-inverse/30;
8383
}
8484

8585
@custom-variant selected {

mock-api/msw/db.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,23 +68,23 @@ export const resolvePoolSelector = (
6868
| { pool: string; type: 'explicit' }
6969
| { type: 'auto'; ip_version?: IpVersion | null }
7070
| undefined,
71-
poolType?: IpPoolType
71+
poolType: IpPoolType,
72+
siloId: string = defaultSilo.id
7273
) => {
7374
if (poolSelector?.type === 'explicit') {
7475
return lookup.ipPool({ pool: poolSelector.pool })
7576
}
7677

7778
// For 'auto' type, find the default pool for the specified IP version and pool type
78-
const silo = lookup.silo({ silo: defaultSilo.id })
79+
const silo = lookup.silo({ silo: siloId })
7980
const links = db.ipPoolSilos.filter((ips) => ips.silo_id === silo.id && ips.is_default)
8081

8182
// Filter candidate pools by both IP version and pool type
8283
const candidateLinks = links.filter((ips) => {
8384
const pool = db.ipPools.find((p) => p.id === ips.ip_pool_id)
8485
if (!pool) return false
8586

86-
// If poolType specified, filter by it
87-
if (poolType && pool.pool_type !== poolType) return false
87+
if (pool.pool_type !== poolType) return false
8888

8989
// If IP version specified, filter by it
9090
if (poolSelector?.ip_version && pool.ip_version !== poolSelector.ip_version) {
@@ -106,9 +106,8 @@ export const resolvePoolSelector = (
106106

107107
const link = candidateLinks[0]
108108
if (!link) {
109-
const typeStr = poolType ? ` ${poolType}` : ''
110109
const versionStr = poolSelector?.ip_version ? ` ${poolSelector.ip_version}` : ''
111-
throw notFoundErr(`default${typeStr}${versionStr} pool for silo '${defaultSilo.id}'`)
110+
throw notFoundErr(`default ${poolType}${versionStr} pool for silo '${siloId}'`)
112111
}
113112
return lookupById(db.ipPools, link.ip_pool_id)
114113
}

0 commit comments

Comments
 (0)