Skip to content

Commit 499f3c7

Browse files
[multicast] default multicast feature across all crates
Enable multicast by default so the packaged artifacts include multicast support without requiring explicit feature flags at build time.
1 parent 3799229 commit 499f3c7

File tree

13 files changed

+11
-12
lines changed

13 files changed

+11
-12
lines changed

.github/buildomat/jobs/image.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ pfexec chown "$UID" /out
101101

102102
banner "P4 Codegen"
103103
# Add gcc-12 so the p4 compiler can find cpp
104-
PATH=/opt/gcc-12/bin:$PATH cargo xtask codegen --stages $TOFINO_STAGES
104+
PATH=/opt/gcc-12/bin:$PATH cargo xtask codegen --stages $TOFINO_STAGES --multicast
105105

106106
# Preserve all the diagnostics spit out by the compiler
107107
mkdir -p /out/p4c-diags

.github/buildomat/jobs/multicast-test.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,4 @@ set -o errexit
3030
set -o pipefail
3131
set -o xtrace
3232

33-
export MULTICAST=1
3433
source .github/buildomat/packet-test-common.sh

.github/buildomat/packet-test-common.sh

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,11 @@ export WS=$wd
88
MODEL_STARTUP_TIMEOUT=${MODEL_STARTUP_TIMEOUT:=5}
99
STARTUP_TIMEOUT=${STARTUP_TIMEOUT:=120}
1010

11-
if [ x$MULTICAST == x ]; then
12-
BUILD_FEATURES=tofino_asic
13-
CODEGEN_FEATURES=
14-
SWADM_FEATURES=
15-
else
16-
BUILD_FEATURES=tofino_asic,multicast
17-
CODEGEN_FEATURES=--multicast
18-
SWADM_FEATURES=--features=multicast
19-
fi
20-
11+
BUILD_FEATURES=tofino_asic
12+
13+
CODEGEN_FEATURES=--multicast
14+
SWADM_FEATURES="--features=multicast"
15+
2116
function cleanup {
2217
set +o errexit
2318
set +o pipefail

HEAD

Whitespace-only changes.

aal/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ version = "0.1.0"
44
edition = "2024"
55

66
[features]
7+
default = ["multicast"]
78
multicast = []
89

910
[dependencies]

asic/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ version = "0.1.0"
44
edition = "2024"
55

66
[features]
7+
default = ["multicast"]
78
tofino_asic = [
89
"dep:lazy_static",
910
"dep:transceiver-controller",

config

Whitespace-only changes.

dpd-client/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ edition = "2024"
55
description = "Client library for the Dendrite data plane daemon"
66

77
[features]
8+
default = ["multicast"]
89
multicast = ["asic/multicast"]
910
chaos = ["asic/chaos"]
1011
tofino_asic = ["asic/tofino_asic"]

dpd/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ authors = ["nils <nils@oxide.computer>"]
55
edition = "2024"
66

77
[features]
8+
default = ["multicast"]
89
multicast = ["aal/multicast", "asic/multicast"]
910
tofino_asic = ["asic/tofino_asic"]
1011
tofino_stub = ["asic/tofino_stub"]

hooks

Whitespace-only changes.

0 commit comments

Comments
 (0)