Skip to content

Commit b931e44

Browse files
gimlet: add missing temperature sensors for the ISL68224 controller (#2108)
This adds app toml metadata and bsp support for ISL68224 controllers on gimlet. --------- Co-authored-by: James Munns <james.munns@oxidecomputer.com>
1 parent 110e6a9 commit b931e44

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/gimlet/base.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,7 @@ device = "isl68224"
991991
description = "DIMM/SP3 1.8V A0 power controller"
992992
power.rails = [ "VPP_ABCD", "VPP_EFGH", "V1P8_SP3" ]
993993
power.phases = [ [ 0 ], [ 1 ], [ 2 ] ]
994-
sensors = { voltage = 3, current = 3 }
994+
sensors = { temperature = 3, voltage = 3, current = 3 }
995995
refdes = "U352"
996996

997997
[[config.i2c.devices]]

task/power/src/bsp/gimlet_bcdef.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ pub(crate) static CONTROLLER_CONFIG: [PowerControllerConfig;
2121
rail_controller!(Core, raa229618, vddcr_soc, A0),
2222
rail_controller!(Mem, raa229618, vdd_mem_abcd, A0),
2323
rail_controller!(Mem, raa229618, vdd_mem_efgh, A0),
24-
rail_controller_notemp!(MemVpp, isl68224, vpp_abcd, A0),
25-
rail_controller_notemp!(MemVpp, isl68224, vpp_efgh, A0),
26-
rail_controller_notemp!(MemVpp, isl68224, v1p8_sp3, A0),
24+
rail_controller!(MemVpp, isl68224, vpp_abcd, A0),
25+
rail_controller!(MemVpp, isl68224, vpp_efgh, A0),
26+
rail_controller!(MemVpp, isl68224, v1p8_sp3, A0),
2727
rail_controller!(Sys, tps546B24A, v3p3_sp_a2, A2),
2828
rail_controller!(Sys, tps546B24A, v3p3_sys_a0, A0),
2929
rail_controller!(Sys, tps546B24A, v5_sys_a2, A2),

0 commit comments

Comments
 (0)