WIP: Obtain Host Panic/Boot Failure Messages#2518
Draft
jamesmunns wants to merge 12 commits into
Draft
Conversation
Co-authored-by: Eliza Weisman <eliza@elizas.website>
hawkw
reviewed
May 19, 2026
jamesmunns
commented
May 19, 2026
| // this would only happen if packrat crashes. We could store some fake info here to | ||
| // continue preparing an ereport, but THAT is going to be a problem anyway because | ||
| // we send ereports to, you guessed it: packrat, which just crashed. | ||
| let response = self |
Contributor
Author
There was a problem hiding this comment.
There's probably something better we can do here as well, the only failure modes for a write_host_bootfail (and host panic) call are:
- That's illegal (not supported, OR client dies and revokes the lease)
- Packrat died
Neither of these are particulary good things (the former doesn't even matter here), and there might be a better way to express the idolatry IPC API to make this more clear in the generated code.
Contributor
Author
|
MGS message changes are tracked in oxidecomputer/management-gateway-service#495. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet complete.
Closes #2504
Currently based on #2503