Skip to content

cosmo_seq: mask STATUS_CML bit 1 to not get annoying pmbus alerts about it#2520

Merged
hawkw merged 5 commits into
masterfrom
eliza/status-cu8lr
May 19, 2026
Merged

cosmo_seq: mask STATUS_CML bit 1 to not get annoying pmbus alerts about it#2520
hawkw merged 5 commits into
masterfrom
eliza/status-cu8lr

Conversation

@hawkw

@hawkw hawkw commented May 19, 2026

Copy link
Copy Markdown
Member

It turns out that PMBus devices like to set this bit bascially any time they saw any kind of I2C behavior that makes them feel uncomfortable. We probably don't want to produce an ereport every time an I2C Thing makes a VRM uncomfortable. So this commit masks out PMBus alerts for STATUS_CML's "other communication fault" bit, since it's annoying and not a big deal.

This branch does a bit of extra refactoring on top of the change from #2511. Since we are now setting even more SMBALERT_MASKs in initialize_pmbus_alerts, I thought it would be nice to have some shared utilities for trying to do this.

@hawkw hawkw changed the title [WIP] mask STATUS_CML bit 2 to not get annoying pmbus alerts about it [WIP] mask STATUS_CML bit 1 to not get annoying pmbus alerts about it May 19, 2026
@hawkw

hawkw commented May 19, 2026

Copy link
Copy Markdown
Member Author

hm this build failure is, i believe, due to GitHub Jank and is not my fault?

@hawkw hawkw changed the title [WIP] mask STATUS_CML bit 1 to not get annoying pmbus alerts about it cosmo_seq: mask STATUS_CML bit 1 to not get annoying pmbus alerts about it May 19, 2026
@hawkw hawkw requested review from jamesmunns and mkeeter May 19, 2026 20:32
@hawkw hawkw marked this pull request as ready for review May 19, 2026 20:32
@hawkw

hawkw commented May 19, 2026

Copy link
Copy Markdown
Member Author

looks like either the same CI weather has occurred again, or Windows CI is now busted in a sticky way that has nothing to do with this PR. imagine that i'm crying, screaming, and throwing up about this, because i certainly am emotionally, if not literally.

@hawkw

hawkw commented May 19, 2026

Copy link
Copy Markdown
Member Author

okay, so i have not actually been able to come up with a way to reproduce a condition that actually asserts this particular bit --- the best i could manage with humility i2c, (writing too many bytes to a register or scanning registers that don't exist) assert bits 5 (PEC failure) and 7 (invalid command) instead. i think asserting bit 1 requires glitching the bus in a way that Humility is too well-behaved to do, such as sending a STOP mid-transaction or just messing with SCL at unexpected moments. i am, however, confident enough that this probably does do the right thing, and have validated that all the refactoring has, at least, not broken the previously working masking of the spurious overcurrent errors. i am going to exercise my best judgement and declare this good enough.

@hawkw hawkw merged commit adbd445 into master May 19, 2026
211 of 509 checks passed
@hawkw hawkw deleted the eliza/status-cu8lr branch May 19, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants