Move registers out of HubrisArchive#655
Open
mkeeter wants to merge 1 commit intomkeeter/revamp-attachfrom
Open
Move registers out of HubrisArchive#655mkeeter wants to merge 1 commit intomkeeter/revamp-attachfrom
HubrisArchive#655mkeeter wants to merge 1 commit intomkeeter/revamp-attachfrom
Conversation
mkeeter
force-pushed
the
mkeeter/no-registers-in-archive
branch
from
60d2361 to
2059901
Compare
mkeeter
force-pushed
the
mkeeter/revamp-attach
branch
from
73ca69e to
95a62e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Staged on #652)
We currently do a strange dance when getting registers out of a dump:
OXIDE_NT_HUBRIS_ARCHIVE) and registers (OXIDE_NT_HUBRIS_REGISTERS)HubrisArchive(so they're only populated if the archive was built from a dump)HubrisArchiveto get the registersThis PR skips that whole dance: when we read the dump to get memory regions, we also get the registers.