review feedback

Author: rcgoodfellow

.github/buildomat/jobs/no-omicron-deps-in-client-crates.sh

@@ -13,8 +13,10 @@
 
 function omicron_dep_check {
   echo "checking $1"
-  pushd $1
-  cargo tree | grep omicron
+  set -e
+  pushd "$1"
+  set +e
+  cargo tree -e normal --all-features | grep omicron
   if [[ $? -ne 1 ]]; then
     echo "$1 may not depend on omicron"
     exit 1
@@ -26,3 +28,4 @@ omicron_dep_check mg-admin-client
 omicron_dep_check ddm-admin-client
 omicron_dep_check ddm-api-types
 omicron_dep_check mg-api-types
+omicron_dep_check mg-api-types/versions