remove unused ServiceNames (#9789)

Author: davepacheco

internal-dns/types/src/names.rs

@@ -68,15 +68,12 @@ pub enum ServiceName {
     OximeterReader,
     ManagementGatewayService,
     RepoDepot,
-    Wicketd,
     Dendrite,
-    Tfport,
     CruciblePantry,
     SledAgent(SledUuid),
     Crucible(OmicronZoneUuid),
     BoundaryNtp,
     InternalNtp,
-    Maghemite, //TODO change to Dpd - maghemite has several services.
     Mgd,
 }
 
@@ -112,15 +109,12 @@ impl ServiceName {
             ServiceName::OximeterReader => "oximeter-reader",
             ServiceName::ManagementGatewayService => "mgs",
             ServiceName::RepoDepot => "repo-depot",
-            ServiceName::Wicketd => "wicketd",
             ServiceName::Dendrite => "dendrite",
-            ServiceName::Tfport => "tfport",
             ServiceName::CruciblePantry => "crucible-pantry",
             ServiceName::SledAgent(_) => "sledagent",
             ServiceName::Crucible(_) => "crucible",
             ServiceName::BoundaryNtp => "boundary-ntp",
             ServiceName::InternalNtp => "internal-ntp",
-            ServiceName::Maghemite => "maghemite",
             ServiceName::Mgd => "mgd",
         }
     }
@@ -146,13 +140,10 @@ impl ServiceName {
             | ServiceName::OximeterReader
             | ServiceName::ManagementGatewayService
             | ServiceName::RepoDepot
-            | ServiceName::Wicketd
             | ServiceName::Dendrite
-            | ServiceName::Tfport
             | ServiceName::CruciblePantry
             | ServiceName::BoundaryNtp
             | ServiceName::InternalNtp
-            | ServiceName::Maghemite
             | ServiceName::Mgd => {
                 format!("_{}._tcp", self.service_kind())
             }

nexus/reconfigurator/planning/src/example.rs

@@ -1819,13 +1819,6 @@ mod tests {
                 | ServiceName::Mgd => {
                     out.insert(service, Ok(()));
                 }
-                // DNS records for Wicketd, Tfportd, and Maghemite don't
-                // currently exist, even on real deployed systems.
-                ServiceName::Wicketd
-                | ServiceName::Tfport
-                | ServiceName::Maghemite => {
-                    out.insert(service, Err(QueryError::NoRecordsFound));
-                }
                 // InternalNtp is too large to fit in a single DNS packet and
                 // therefore times out, but DNS lookups for it aren't used
                 // anywhere. See #9178.