[nexus] instance update saga: retry "inherit lock", too #10801
Open
hawkw wants to merge 2 commits into
Open
Conversation
Similarly to #10166, a duplicate execution of the `siu_become_updater` saga action, which attempts to inherit the lock from the parent `start_instance_update` saga, must never fail if a previous execution of that node has already marked the instance record as locked. Like in PR #10177, which fixed #10166, we can resolve this by adding a retry loop that should retry any transient database errors indefinitely. And, as we discovered in #10785, the exception to this rule is cases where the instance record has been deleted, so we handle that gracefully here as well (or at least we will, once #10787 actually fixes the lock inheriting query's handling of deleted instance records...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #10166, a duplicate execution of the
siu_become_updatersaga action, which attempts to inherit the lock from the parent
start_instance_updatesaga, must never fail if a previous execution ofthat node has already marked the instance record as locked. Like in PR
#10177, which fixed #10166, we can resolve this by adding a retry loop
that should retry any transient database errors indefinitely. And, as we
discovered in #10785, the exception to this rule is cases where the
instance record has been deleted, so we handle that gracefully here as
well (or at least we will, once #10787 actually fixes the lock
inheriting query's handling of deleted instance records...).