replace unnecessary use of write! with Formatter::write_str (#840)

Author: ahl

typify-impl/src/type_entry.rs

@@ -816,14 +816,16 @@ impl TypeEntry {
                     impl ::std::fmt::Display for #type_name {
                         fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
                             match *self {
-                                #(Self::#match_variants => write!(f, #match_strs),)*
+                                #(Self::#match_variants => f.write_str(#match_strs),)*
                             }
                         }
                     }
                     impl ::std::str::FromStr for #type_name {
                         type Err = self::error::ConversionError;
 
-                        fn from_str(value: &str) -> ::std::result::Result<Self, self::error::ConversionError> {
+                        fn from_str(value: &str) ->
+                            ::std::result::Result<Self, self::error::ConversionError>
+                        {
                             match value {
                                 #(#match_strs => Ok(Self::#match_variants),)*
                                 _ => Err("invalid value".into()),

typify-impl/tests/generator.out

@@ -196,9 +196,9 @@ mod types {
     impl ::std::fmt::Display for StringEnum {
         fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
             match *self {
-                Self::One => write!(f, "One"),
-                Self::Two => write!(f, "Two"),
-                Self::BuckleMyShoe => write!(f, "BuckleMyShoe"),
+                Self::One => f.write_str("One"),
+                Self::Two => f.write_str("Two"),
+                Self::BuckleMyShoe => f.write_str("BuckleMyShoe"),
             }
         }
     }

typify-impl/tests/github.out

@@ -111,8 +111,8 @@ impl ::std::convert::From<&Self> for LetterBoxLetter {
 impl ::std::fmt::Display for LetterBoxLetter {
     fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
         match *self {
-            Self::A => write!(f, "a"),
-            Self::B => write!(f, "b"),
+            Self::A => f.write_str("a"),
+            Self::B => f.write_str("b"),
         }
     }
 }

typify-impl/tests/vega.out

@@ -364,7 +364,7 @@ impl ::std::convert::From<&Self> for JsonSuccessBaseResult {
 impl ::std::fmt::Display for JsonSuccessBaseResult {
     fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
         match *self {
-            Self::Success => write!(f, "success"),
+            Self::Success => f.write_str("success"),
         }
     }
 }
@@ -436,7 +436,7 @@ impl ::std::convert::From<&Self> for JsonSuccessResult {
 impl ::std::fmt::Display for JsonSuccessResult {
     fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
         match *self {
-            Self::Success => write!(f, "success"),
+            Self::Success => f.write_str("success"),
         }
     }
 }
@@ -952,7 +952,7 @@ impl ::std::convert::From<&Self> for UnchangedByMergeTag {
 impl ::std::fmt::Display for UnchangedByMergeTag {
     fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
         match *self {
-            Self::Something => write!(f, "something"),
+            Self::Something => f.write_str("something"),
         }
     }
 }
@@ -1278,7 +1278,7 @@ impl ::std::convert::From<&Self> for Unsatisfiable3B {
 impl ::std::fmt::Display for Unsatisfiable3B {
     fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
         match *self {
-            Self::Bar => write!(f, "bar"),
+            Self::Bar => f.write_str("bar"),
         }
     }
 }
@@ -1350,7 +1350,7 @@ impl ::std::convert::From<&Self> for Unsatisfiable3C {
 impl ::std::fmt::Display for Unsatisfiable3C {
     fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
         match *self {
-            Self::Foo => write!(f, "foo"),
+            Self::Foo => f.write_str("foo"),
         }
     }
 }