refactor!: remove non-idiomatic From<&String> trait impls (#946)

Author: danieleades

cargo-typify/README.md

@@ -90,12 +90,6 @@ impl std::convert::TryFrom<&str> for IdOrName {
         value.parse()
     }
 }
-impl std::convert::TryFrom<&String> for IdOrName {
-    type Error = &'static str;
-    fn try_from(value: &String) -> Result<Self, &'static str> {
-        value.parse()
-    }
-}
 impl std::convert::TryFrom<String> for IdOrName {
     type Error = &'static str;
     fn try_from(value: String) -> Result<Self, &'static str> {
@@ -156,12 +150,6 @@ impl std::convert::TryFrom<&str> for Name {
         value.parse()
     }
 }
-impl std::convert::TryFrom<&String> for Name {
-    type Error = &'static str;
-    fn try_from(value: &String) -> Result<Self, &'static str> {
-        value.parse()
-    }
-}
 impl std::convert::TryFrom<String> for Name {
     type Error = &'static str;
     fn try_from(value: String) -> Result<Self, &'static str> {

typify-impl/src/type_entry.rs

@@ -1427,16 +1427,6 @@ impl TypeEntry {
                                     value.parse()
                                 }
                             }
-                            impl ::std::convert::TryFrom<&String> for #type_name {
-                                type Error = <#inner_type_name as
-                                    ::std::str::FromStr>::Err;
-
-                                fn try_from(value: &String) ->
-                                    ::std::result::Result<Self, Self::Error>
-                                {
-                                    value.parse()
-                                }
-                            }
                             impl ::std::convert::TryFrom<String> for #type_name {
                                 type Error = <#inner_type_name as
                                     ::std::str::FromStr>::Err;

typify/tests/schemas/merged-schemas.rs

@@ -529,12 +529,6 @@ impl ::std::convert::TryFrom<&str> for NarrowNumber {
         value.parse()
     }
 }
-impl ::std::convert::TryFrom<&String> for NarrowNumber {
-    type Error = <::std::num::NonZeroU64 as ::std::str::FromStr>::Err;
-    fn try_from(value: &String) -> ::std::result::Result<Self, Self::Error> {
-        value.parse()
-    }
-}
 impl ::std::convert::TryFrom<String> for NarrowNumber {
     type Error = <::std::num::NonZeroU64 as ::std::str::FromStr>::Err;
     fn try_from(value: String) -> ::std::result::Result<Self, Self::Error> {

typify/tests/schemas/noisy-types.rs

@@ -114,12 +114,6 @@ impl ::std::convert::TryFrom<&str> for IntegerBs {
         value.parse()
     }
 }
-impl ::std::convert::TryFrom<&String> for IntegerBs {
-    type Error = <u64 as ::std::str::FromStr>::Err;
-    fn try_from(value: &String) -> ::std::result::Result<Self, Self::Error> {
-        value.parse()
-    }
-}
 impl ::std::convert::TryFrom<String> for IntegerBs {
     type Error = <u64 as ::std::str::FromStr>::Err;
     fn try_from(value: String) -> ::std::result::Result<Self, Self::Error> {