Merged
Conversation
ghost
changed the title
ahl
approved these changes
Dec 26, 2025
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
Excellent! Thanks for this. It seems like they only way one could hit this today would be if a property of the $defs object was named something like "foo/bar" -- did you hit this in schema in the wild?
Author
Yes, I was trying to use a JSON Schema generated by Effect, where "identifiers" are used for definition names, and these identifiers commonly include the name of the module separated by slashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The characters
~and/have special meanings in JSON Pointer, so they must be encoded as~0and~1, respectively. Previously, Typify did not handle decoding these properly. This PR implements decoding forref_name, allowing these characters to be correctly unescaped.See: https://github.com/GREsau/schemars/blob/ac0b65131d2c27017fee3e8b641cdfd6dac4f841/schemars/src/encoding.rs#L7