Type argument is now optional#7
Open
burdier wants to merge 1 commit into
Open
Conversation
ozanonurtek
reviewed
Oct 13, 2019
Owner
ozanonurtek
left a comment
ozanonurtek
left a comment
There was a problem hiding this comment.
I like the way you think and I'll try it on my machine 👍 It looks good
Author
Nice. |
ozanonurtek
requested changes
Oct 19, 2019
Owner
ozanonurtek
left a comment
ozanonurtek
left a comment
There was a problem hiding this comment.
boilerplate_code.get(app_type,'simple')
This returns 'simple' if app_type not in boilerplate dictionary and because of that shutil throws:
No such file or directory: 'simple'
instead of just 'simple' we should create a fallback for: '{directory_name}/flask_now/templates/simple'.
Could you please review your code and refactor it for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it makes sense to have a template by default