@@ -16,26 +16,26 @@ import (
1616var errInvalidArguments = errors .New ("invalid arguments" )
1717
1818// CreateTableAs ...
19- func CreateTableAs (ctx context.Context , shard database.Shard , database , srcTable , dstTable string ) error {
20- if sqlUtils .ValidateEntityName (database ) != nil || sqlUtils .ValidateEntityName (srcTable ) != nil || sqlUtils .ValidateEntityName (dstTable ) != nil {
19+ func CreateTableAs (ctx context.Context , shard database.Shard , databaseName , srcTableName , dstTableName string ) error {
20+ if sqlUtils .ValidateEntityName (databaseName ) != nil || sqlUtils .ValidateEntityName (srcTableName ) != nil || sqlUtils .ValidateEntityName (dstTableName ) != nil {
2121 return errInvalidArguments
2222 }
2323
24- if err := shard .Exec (ctx , fmt .Sprintf ("CREATE TABLE %s AS %s" , sqlUtils .QuotedDatabaseEntity (database , dstTable ), sqlUtils .QuotedDatabaseEntity (database , srcTable ))); err != nil {
25- return fmt .Errorf ("failed to create table %s as %s in %s: %w" , dstTable , srcTable , database , err )
24+ if err := shard .Exec (ctx , fmt .Sprintf ("CREATE TABLE %s AS %s" , sqlUtils .QuotedDatabaseEntity (databaseName , dstTableName ), sqlUtils .QuotedDatabaseEntity (databaseName , srcTableName ))); err != nil {
25+ return fmt .Errorf ("failed to create table %s as %s in %s: %w" , dstTableName , srcTableName , databaseName , err )
2626 }
2727
2828 return nil
2929}
3030
3131// DropTable ...
32- func DropTable (ctx context.Context , shard database.Shard , database , table string ) error {
33- if sqlUtils .ValidateEntityName (database ) != nil || sqlUtils .ValidateEntityName (table ) != nil {
32+ func DropTable (ctx context.Context , shard database.Shard , databaseName , tableName string ) error {
33+ if sqlUtils .ValidateEntityName (databaseName ) != nil || sqlUtils .ValidateEntityName (tableName ) != nil {
3434 return errInvalidArguments
3535 }
3636
37- if err := shard .Exec (ctx , "DROP TABLE " + sqlUtils .QuotedDatabaseEntity (database , table )); err != nil {
38- return fmt .Errorf ("failed to drop table %s in %s: %w" , table , database , err )
37+ if err := shard .Exec (ctx , "DROP TABLE " + sqlUtils .QuotedDatabaseEntity (databaseName , tableName )); err != nil {
38+ return fmt .Errorf ("failed to drop table %s in %s: %w" , tableName , databaseName , err )
3939 }
4040
4141 return nil
0 commit comments