⬆️ update p-chess and phpunit

Author: garak

.github/workflows/build.yaml

@@ -10,7 +10,7 @@ jobs:
         name: PHPStan
         steps:
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
             - name: PHPStan
               uses: docker://oskarstark/phpstan-ga:1.8.0
               env:
@@ -22,9 +22,11 @@ jobs:
         name: PHP-CS-Fixer
         steps:
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
             - name: Fix CS
               uses: docker://oskarstark/php-cs-fixer-ga
+              with:
+                args: --diff --dry-run
     tests:
         runs-on: ubuntu-24.04
         strategy:
@@ -41,16 +43,16 @@ jobs:
                     - description: 'Symfony 6.4'
                       php: '8.3'
                       symfony: 6.4.*
-                    - description: 'Symfony 7.2'
+                    - description: 'Symfony 7.3'
                       php: '8.4'
-                      symfony: 7.2.*
+                      symfony: 7.3.*
         name: PHP ${{ matrix.php }} tests (${{ matrix.description }})
         steps:
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
             - name: Cache
-              uses: actions/cache@v3
-              with: 
+              uses: actions/cache@v4
+              with:
                   path: ~/.composer/cache/files
                   key: ${{ matrix.php }}-${{ matrix.symfony }}-${{ matrix.composer_option }} 
             - name: Setup PHP

composer.json

@@ -20,17 +20,17 @@
     ],
     "require": {
         "php": "^8.1",
-        "p-chess/chess": "^0.6",
+        "p-chess/chess": "^0.7",
         "symfony/config": "^6.4 || ^7.0",
         "symfony/dependency-injection": "^6.4 || ^7.0",
         "symfony/http-kernel": "^6.4 || ^7.0",
         "symfony/routing": "^6.4 || ^7.0",
         "twig/twig": "^3.18"
     },
     "require-dev": {
-        "dg/bypass-finals": "^1.6",
-        "phpunit/phpunit": "^9.6",
-        "symfony/phpunit-bridge": "^7.2"
+        "dg/bypass-finals": "^1.9",
+        "phpunit/phpunit": "^10.5 || ^11.5 || ^12.3",
+        "symfony/phpunit-bridge": "^7.3"
     },
     "config": {
         "sort-packages": true

phpunit.xml.dist

@@ -1,9 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit 
     colors="true"
-    convertErrorsToExceptions="true"
-    convertNoticesToExceptions="true"
-    convertWarningsToExceptions="true"
     beStrictAboutTestsThatDoNotTestAnything="true"
     bootstrap="vendor/autoload.php"
 >
@@ -13,14 +10,14 @@
         </testsuite>
     </testsuites>
 
-    <coverage>
+    <source>
         <include>
             <directory>src</directory>
         </include>
-    </coverage>
+    </source>
 
     <!-- see https://www.tomasvotruba.cz/blog/2019/03/28/how-to-mock-final-classes-in-phpunit/ -->
     <extensions>
-        <extension class="PChess\ChessBundle\Tests\BypassFinalHook"/>
+        <bootstrap class="PChess\ChessBundle\Tests\BypassFinalExtension"/>
     </extensions>
 </phpunit>

src/Twig/ChessExtension.php

@@ -2,7 +2,6 @@
 
 namespace PChess\ChessBundle\Twig;
 
-use PChess\ChessBundle\HtmlOutput;
 use Twig\Extension\AbstractExtension;
 use Twig\TwigFunction;
 

src/Twig/ChessRuntime.php

@@ -5,7 +5,6 @@
 use PChess\Chess\Chess;
 use PChess\ChessBundle\HtmlOutput;
 use Twig\Extension\AbstractExtension;
-use Twig\TwigFunction;
 
 final class ChessRuntime extends AbstractExtension
 {

tests/BypassFinalExtension.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace PChess\ChessBundle\Tests;
+
+use DG\BypassFinals;
+use PHPUnit\Runner\Extension\Extension;
+use PHPUnit\Runner\Extension\Facade;
+use PHPUnit\Runner\Extension\ParameterCollection;
+use PHPUnit\TextUI\Configuration\Configuration;
+
+final class BypassFinalExtension implements Extension
+{
+    public function bootstrap(Configuration $configuration, Facade $facade, ParameterCollection $parameters): void
+    {
+        BypassFinals::enable();
+    }
+}

tests/BypassFinalHook.php

@@ -3,7 +3,6 @@
 namespace PChess\ChessBundle\Tests\DependencyInjection;
 
 use PChess\ChessBundle\DependencyInjection\CompilerPass;
-use PChess\ChessBundle\Twig\ChessRuntime;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
@@ -18,8 +17,7 @@ public function testProcess(): void
         /** @var ContainerBuilder&\PHPUnit\Framework\MockObject\MockObject $container */
         $container = $this->createMock(ContainerBuilder::class);
         $container->expects(self::once())->method('getParameter')->with('chess.output_service')->willReturn('foo');
-        $container->expects(self::at(1))->method('getDefinition')->with('foo')->willReturn($definition);
-        $container->expects(self::at(2))->method('getDefinition')->with(ChessRuntime::class)->willReturn($definition);
+        $container->method('getDefinition')->willReturn($definition);
         $pass = new CompilerPass();
         $pass->process($container);
     }

tests/DependencyInjection/CompilerPassTest.php

@@ -7,7 +7,7 @@
 use PChess\Chess\Piece;
 use PChess\ChessBundle\Mover;
 
-final class MoverTest extends \PHPUnit\Framework\TestCase
+final class MoverTest extends PHPUnit\Framework\TestCase
 {
     public function testGetAllowedMoves(): void
     {