[javascript] Create new Fortune object in scope of request

p8 · p8 · commit 2ad1b9bd58c3 · 2026-02-11T09:30:17.000+01:00
The new fortune object must be constructed in the scope of the request, not as a constant: > Within the scope of the request, a new Fortune object must be constructed and added to the list. https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#fortunes
diff --git a/frameworks/JavaScript/express/src/server.mjs b/frameworks/JavaScript/express/src/server.mjs
@@ -20,7 +20,10 @@ const cache = new LRUCache({
   max: maxRows
 });
 
-const extra = { id: 0, message: "Additional fortune added at request time." };
+const extra = () => ({
+  id: 0,
+  message: "Additional fortune added at request time."
+});
 
 const app = express();
 
@@ -65,7 +68,7 @@ if (db) {
 
   app.get("/fortunes", async (req, res) => {
     const rows = await db.fortunes();
-    rows.push(extra);
+    rows.push(extra());
     rows.sort((a, b) => (a.message < b.message) ? -1 : 1);
     const n = rows.length;
     let html = "",
@@ -126,4 +129,4 @@ const port = parseInt(process.env.PORT || "8080");
 const server =app.listen(port, host, () => {
   console.log(`Server running at http://${host}:${port}/`);
 });
-server.keepAliveTimeout = 0;
+server.keepAliveTimeout = 0;
diff --git a/frameworks/JavaScript/fastify/handlers.js b/frameworks/JavaScript/fastify/handlers.js
@@ -27,7 +27,7 @@ module.exports = (databaseLayer) => ({
   fortunes: async (req, reply) => {
     const fortunes = await databaseLayer.allFortunes();
 
-    fortunes.push(h.additionalFortune);
+    fortunes.push(h.additionalFortune());
     fortunes.sort(compare);
 
     return reply.view("/views/fortunes.hbs", { fortunes });
diff --git a/frameworks/JavaScript/fastify/helper.js b/frameworks/JavaScript/fastify/helper.js
@@ -5,8 +5,8 @@ module.exports = {
     return Math.min(Math.max(parseInt(queries) || 1, 1), 500);
   },
 
-  additionalFortune: {
+  additionalFortune: () => ({
     id: 0,
     message: "Additional fortune added at request time.",
-  },
+  }),
 };
diff --git a/frameworks/JavaScript/hono/src/server.js b/frameworks/JavaScript/hono/src/server.js
@@ -26,7 +26,10 @@ app
   });
 
 if (db) {
-  const extra = { id: 0, message: "Additional fortune added at request time." };
+  const extra = () => ({
+    id: 0,
+    message: "Additional fortune added at request time."
+  });
 
   app
     .get("/db", async (c) => {
@@ -49,7 +52,7 @@ if (db) {
       return c.json(worldObjects);
     })
     .get("/fortunes", async (c) => {
-      const rows = [extra, ...(await db.fortunes())];
+      const rows = [extra(), ...(await db.fortunes())];
 
       sortByMessage(rows);
 
diff --git a/frameworks/JavaScript/spliffy/www/fortunes.rt.js b/frameworks/JavaScript/spliffy/www/fortunes.rt.js
@@ -1,10 +1,10 @@
 const db = require('../db')
 const { escape } = require('html-escaper')
 
-const runTimeFortune = {
+const runTimeFortune = () => ({
     id: 0,
     message: 'Additional fortune added at request time.'
-}
+})
 
 function sortByMessage(arr) {
     const n = arr.length
@@ -23,9 +23,9 @@ function sortByMessage(arr) {
 module.exports = {
     GET: async ({ res }) => {
         let fortunes = await db.allFortunes()
-        fortunes.push(runTimeFortune)
+        fortunes.push(runTimeFortune())
         sortByMessage(fortunes)
-        
+
         let html = '<!DOCTYPE html><html><head><title>Fortunes</title></head><body><table><tr><th>id</th><th>message</th></tr>';
         for (let i = 0; i < fortunes.length; i++) {
             html += `<tr><td>${fortunes[i].id}</td><td>${escape(fortunes[i].message)}</td></tr>`;
diff --git a/frameworks/JavaScript/uwebsockets.js/src/server.js b/frameworks/JavaScript/uwebsockets.js/src/server.js
@@ -93,15 +93,18 @@ if (db) {
     }
   });
 
-  const extra = { id: 0, message: "Additional fortune added at request time." };
+  const extra = () => ({
+    id: 0,
+    message: "Additional fortune added at request time."
+  });
 
   webserver.get("/fortunes", async (response) => {
     response.onAborted(() => {
       response.aborted = true;
     });
 
     try {
-      const rows = [extra, ...await db.fortunes()];
+      const rows = [extra(), ...await db.fortunes()];
 
       if (response.aborted) {
         return;
