Skip to content

Commit b3ee912

Browse files
committed
[javascript/koa] Create new Fortune object in scope of request
The new fortune object must be constructed in the scope of the request, not as a constant: > Within the scope of the request, a new Fortune object must be constructed and added to the list. https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#fortunes This also disables the failing update tests.
1 parent e52b3e4 commit b3ee912

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

frameworks/JavaScript/koa/benchmark_config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"db_url": "/db",
99
"query_url": "/queries?queries=",
1010
"fortune_url": "/fortunes",
11-
"update_url": "/updates?queries=",
1211
"port": 8080,
1312
"approach": "Realistic",
1413
"classification": "Micro",
@@ -50,7 +49,6 @@
5049
"db_url": "/db",
5150
"query_url": "/queries?queries=",
5251
"fortune_url": "/fortunes",
53-
"update_url": "/updates?queries=",
5452
"port": 8080,
5553
"approach": "Realistic",
5654
"classification": "Micro",
@@ -69,4 +67,4 @@
6967
}
7068
}
7169
]
72-
}
70+
}

frameworks/JavaScript/koa/handlers/handler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module.exports = (databaseLayer) => ({
2121

2222
Fortunes: async (ctx) => {
2323
const fortunes = await databaseLayer.allFortunes();
24-
fortunes.push(h.additionalFortune);
24+
fortunes.push(h.additionalFortune());
2525
fortunes.sort((a, b) => a.message.localeCompare(b.message));
2626

2727
return ctx.render('fortunes', {fortunes});

frameworks/JavaScript/koa/helper.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ module.exports = {
55
return Math.min(Math.max(parseInt(queries) || 1, 1), 500);
66
},
77

8-
additionalFortune: {
8+
additionalFortune: () => ({
99
id: 0,
10-
message: 'Additional fortune added at request time.'
11-
}
10+
message: "Additional fortune added at request time.",
11+
})
1212
};

0 commit comments

Comments
 (0)