Skip to content

Commit db940f0

Browse files
committed
Make sure isValidEmail and isValidUrl return a boolean
1 parent 7e2d418 commit db940f0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Command/Markdown/Generator.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,18 +236,18 @@ private function promptDestinationFile(): Question
236236
);
237237
}
238238

239-
private function isFieldFilled(string? $string): bool
239+
private function isFieldFilled(?string $string): bool
240240
{
241241
return !empty($string) && strlen($string) > 0;
242242
}
243243

244244
private function isValidEmail(string $email): bool
245245
{
246-
return filter_var($email, FILTER_VALIDATE_EMAIL);
246+
return filter_var($email, FILTER_VALIDATE_EMAIL) !== false;
247247
}
248248

249249
private function isValidUrl(string $url): bool
250250
{
251-
return filter_var($url, FILTER_VALIDATE_URL);
251+
return filter_var($url, FILTER_VALIDATE_URL) !== false;
252252
}
253253
}

0 commit comments

Comments
 (0)