Fix

Author: paceholder

test/src/TestDataFlowGraphModel.cpp

@@ -1,7 +1,7 @@
 #include "ApplicationSetup.hpp"
-#include "StubNodeDataModel.hpp"
 
 #include <QtNodes/DataFlowGraphModel>
+#include <QtNodes/NodeDelegateModel>
 #include <QtNodes/NodeDelegateModelRegistry>
 #include <QtNodes/Definitions>
 
@@ -10,12 +10,13 @@
 using QtNodes::ConnectionId;
 using QtNodes::DataFlowGraphModel;
 using QtNodes::InvalidNodeId;
+using QtNodes::NodeDelegateModel;
 using QtNodes::NodeDelegateModelRegistry;
 using QtNodes::NodeId;
 using QtNodes::NodeRole;
 using QtNodes::PortType;
 
-class TestNodeDelegate : public StubNodeDataModel
+class TestNodeDelegate : public NodeDelegateModel
 {
 public:
     QString name() const override { return "TestNode"; }
@@ -24,6 +25,10 @@ class TestNodeDelegate : public StubNodeDataModel
     {
         return (portType == PortType::In) ? 2 : 1;
     }
+    QtNodes::NodeDataType dataType(QtNodes::PortType, QtNodes::PortIndex) const override { return {}; }
+    void setInData(std::shared_ptr<QtNodes::NodeData>, QtNodes::PortIndex const) override {}
+    std::shared_ptr<QtNodes::NodeData> outData(QtNodes::PortIndex const) override { return nullptr; }
+    QWidget* embeddedWidget() override { return nullptr; }
 };
 
 TEST_CASE("DataFlowGraphModel basic functionality", "[dataflow]")

test/src/TestNodeDelegateModelRegistry.cpp

@@ -1,21 +1,26 @@
-#include "StubNodeDataModel.hpp"
-
+#include <QtNodes/NodeDelegateModel>
 #include <QtNodes/NodeDelegateModelRegistry>
 
 #include <catch2/catch.hpp>
 
+using QtNodes::NodeDelegateModel;
 using QtNodes::NodeDelegateModelRegistry;
 
 namespace {
-class TestModelWithStaticName : public StubNodeDataModel
+class TestModelWithStaticName : public NodeDelegateModel
 {
 public:
     static QString Name() { return "StaticNameModel"; }
     QString name() const override { return "StaticNameModel"; }
     QString caption() const override { return "Static Name Model"; }
+    unsigned int nPorts(QtNodes::PortType) const override { return 0; }
+    QtNodes::NodeDataType dataType(QtNodes::PortType, QtNodes::PortIndex) const override { return {}; }
+    void setInData(std::shared_ptr<QtNodes::NodeData>, QtNodes::PortIndex const) override {}
+    std::shared_ptr<QtNodes::NodeData> outData(QtNodes::PortIndex const) override { return nullptr; }
+    QWidget* embeddedWidget() override { return nullptr; }
 };
 
-class TestModelWithName : public StubNodeDataModel
+class TestModelWithName : public NodeDelegateModel
 {
 public:
     TestModelWithName(const QString &name = "DefaultName")
@@ -24,6 +29,11 @@ class TestModelWithName : public StubNodeDataModel
 
     QString name() const override { return _modelName; }
     QString caption() const override { return QString("Model: %1").arg(_modelName); }
+    unsigned int nPorts(QtNodes::PortType) const override { return 0; }
+    QtNodes::NodeDataType dataType(QtNodes::PortType, QtNodes::PortIndex) const override { return {}; }
+    void setInData(std::shared_ptr<QtNodes::NodeData>, QtNodes::PortIndex const) override {}
+    std::shared_ptr<QtNodes::NodeData> outData(QtNodes::PortIndex const) override { return nullptr; }
+    QWidget* embeddedWidget() override { return nullptr; }
 
 private:
     QString _modelName;

test/src/TestSerialization.cpp

@@ -1,7 +1,7 @@
 #include "ApplicationSetup.hpp"
-#include "StubNodeDataModel.hpp"
 
 #include <QtNodes/DataFlowGraphModel>
+#include <QtNodes/NodeDelegateModel>
 #include <QtNodes/NodeDelegateModelRegistry>
 #include <QtNodes/Definitions>
 
@@ -15,11 +15,12 @@
 using QtNodes::ConnectionId;
 using QtNodes::DataFlowGraphModel;
 using QtNodes::InvalidNodeId;
+using QtNodes::NodeDelegateModel;
 using QtNodes::NodeDelegateModelRegistry;
 using QtNodes::NodeId;
 using QtNodes::NodeRole;
 
-class SerializableTestModel : public StubNodeDataModel
+class SerializableTestModel : public NodeDelegateModel
 {
 public:
     QString name() const override { return "SerializableTestModel"; }
@@ -29,6 +30,10 @@ class SerializableTestModel : public StubNodeDataModel
     {
         return (portType == QtNodes::PortType::In) ? 1 : 1;
     }
+    QtNodes::NodeDataType dataType(QtNodes::PortType, QtNodes::PortIndex) const override { return {}; }
+    void setInData(std::shared_ptr<QtNodes::NodeData>, QtNodes::PortIndex const) override {}
+    std::shared_ptr<QtNodes::NodeData> outData(QtNodes::PortIndex const) override { return nullptr; }
+    QWidget* embeddedWidget() override { return nullptr; }
 };
 
 TEST_CASE("DataFlowGraphModel serialization", "[serialization]")