Merge pull request #28 from FrostyX/fedora-review

Implement fedora-review plan

Author: LecrisUT

plans/fedora-review/README.md

@@ -0,0 +1,8 @@
+# Fedora Review
+
+Run [fedora-review] on the current Copr project or Koji build
+
+See this discussion for more
+https://discussion.fedoraproject.org/t/running-fedora-review-on-every-commit/178858
+
+[fedora-review]: https://pagure.io/FedoraReview

plans/fedora-review/main.fmf

@@ -0,0 +1,18 @@
+summary: Run fedora-review on all rpms and spec file
+
+description: |
+  See this discussion for more
+  https://discussion.fedoraproject.org/t/running-fedora-review-on-every-commit/178858
+
+# We need a full VM because fedora-review does things inside of Mock, which
+# AFAIK cannot run inside a container yet.
+# https://github.com/rpm-software-management/mock/issues/1487
+# https://github.com/rpm-software-management/mock/issues/217
+# https://github.com/rpm-software-management/mock/issues/192
+provision:
+  how: virtual
+  image: fedora
+
+discover:
+  how: fmf
+  test: /tests/fedora-review

tests/fedora-review/copr-prepare.py

@@ -0,0 +1 @@
+../rpmlint/copr-prepare.py

tests/fedora-review/distgit-prepare.py

@@ -0,0 +1 @@
+../rpmlint/distgit-prepare.py

tests/fedora-review/main.fmf

@@ -0,0 +1,39 @@
+/:
+  inherit: false
+
+/prepare-distgit:
+  summary: Prepare with distgit environment
+  enabled: false
+  duration: 30m
+  order: 40
+  require:
+    - koji
+    - git
+  test: python3 ./distgit-prepare.py
+  adjust:
+    # TODO: For now this is only available for distgit commits
+    when: initiator == fedora-ci and trigger == commit
+    enabled: true
+
+/prepare-copr:
+  summary: Prepare with copr environment
+  enabled: false
+  duration: 30m
+  order: 40
+  require:
+    - copr
+    - git
+  test: python3 ./copr-prepare.py
+  adjust:
+    when: initiator == packit
+    enabled: true
+
+/run-fedora-review:
+  summary: Run fedora-review
+  duration: 30m
+  description: |
+    Requires having some environment variables predefined.
+    See documentation of the run-fedora-review script.
+  require:
+    - fedora-review
+  test: python3 ./run-fedora-review.py

tests/fedora-review/run-fedora-review.py

@@ -0,0 +1,68 @@
+#!/usr/bin/python3
+
+import sys
+import argparse
+import os
+import subprocess
+import shutil
+from pathlib import Path
+
+
+def main(args: argparse.Namespace) -> None:
+    """
+    Run fedora-review
+    """
+    if not args.spec_file:
+        raise RuntimeError("No spec file provided")
+
+    if not args.rpm_files:
+        raise RuntimeError("No RPM files provided")
+
+    # At this point, the RPM packages are already downloaded in `args.workdir`,
+    # we just need to copy the .spec next to them
+    shutil.copy(args.spec_file, args.workdir)
+
+    env = os.environ.copy()
+    env["REVIEW_NO_MOCKGROUP_CHECK"] = "true"
+
+    name = Path(args.spec_file).stem
+    cmd = ["fedora-review", "--prebuilt", "-n", name]
+    print(f"Running: {" ".join(cmd)}")
+    subprocess.run(cmd, cwd=args.workdir, env=env, check=True)
+
+    result = os.path.join(args.workdir, "review-" + name, "review.json")
+    if not os.path.exists(result):
+        raise RuntimeError(f"Result JSON doesn't exist: {result}")
+
+    print("Result: {0}".format(result))
+
+
+if __name__ == "__main__":
+    parser = argparse.ArgumentParser(
+        description=(
+            "Simple wrapper for fedora-review. "
+            "Can also pass variables via environment variables."
+        )
+    )
+    parser.add_argument(
+        "--workdir",
+        type=Path,
+        default=os.environ.get("TMT_PLAN_DATA", "."),
+    )
+    parser.add_argument(
+        "--spec-file",
+        help="Spec file to check.",
+        default=os.environ.get("SPEC_FILE"),
+    )
+    parser.add_argument(
+        "--rpm-files",
+        help="RPM files to check. Can be wildcard.",
+        default=os.environ.get("RPM_FILES"),
+    )
+
+    args = parser.parse_args()
+    try:
+        main(args)
+    except RuntimeError as ex:
+        print(ex, file=sys.stderr)
+        sys.exit(1)