major upgrade smqp@10

adjust lint rules

Author: paed01

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## [17.2.0] - 2025-07-22
+
+- major upgrade of [smqp@10.0.0](https://github.com/paed01/smqp/blob/default/CHANGELOG.md)
+
 ## [17.1.0] - 2025-04-30
 
 - add support for ad-hoc subprocess. The behavior is the same as for an ordinary subprocess

dist/process/Process.js

@@ -314,7 +314,7 @@ Process.prototype._onRunMessage = function onRunMessage(routingKey, message) {
         const {
           output,
           ...rest
-        } = content; // eslint-disable-line no-unused-vars
+        } = content;
         this._publishEvent('leave', rest);
         return;
       }

eslint.config.js

@@ -42,9 +42,17 @@ const rules = {
   'no-undef-init': 2,
   'no-undef': 2,
   'no-underscore-dangle': 0,
-  'no-unused-vars': 2,
   'no-unused-expressions': 2,
-  'no-use-before-define': 0,
+  'no-unused-vars': ['error', { ignoreRestSiblings: true }],
+  'no-use-before-define': [
+    'error',
+    {
+      functions: false,
+      classes: true,
+      variables: true,
+      allowNamedExports: false,
+    },
+  ],
   'no-var': 2,
   'no-with': 2,
   'prefer-const': ['error', { destructuring: 'all' }],

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmn-elements",
-  "version": "17.1.0",
+  "version": "17.2.0",
   "description": "Executable workflow elements based on BPMN 2.0",
   "type": "module",
   "main": "./dist/index.js",
@@ -104,6 +104,6 @@
   },
   "dependencies": {
     "@0dep/piso": "^2.4.0",
-    "smqp": "^9.0.6"
+    "smqp": "^10.0.0"
   }
 }

src/process/Process.js

@@ -306,7 +306,7 @@ Process.prototype._onRunMessage = function onRunMessage(routingKey, message) {
       this[kStatus] = undefined;
       message.ack();
       this._deactivateRunConsumers();
-      const { output, ...rest } = content; // eslint-disable-line no-unused-vars
+      const { output, ...rest } = content;
       this._publishEvent('leave', rest);
       return;
     }

test/feature/compensation-feature.js

@@ -797,7 +797,10 @@ Feature('Compensation', () => {
       });
     });
 
+    let end;
     When('definition is ran', () => {
+      end = definition.waitFor('end');
+
       definition.run();
     });
 
@@ -874,7 +877,6 @@ Feature('Compensation', () => {
       return stopped;
     });
 
-    let end;
     When('definition is recovered and resumed', () => {
       definition = new Definition(context.clone(), {
         services: {

test/feature/issues/issue-39-feature.js

@@ -21,6 +21,27 @@ const source = `
   </process>
 </definitions>`;
 
+class FlorianSequenceFlow extends SequenceFlow {
+  getCondition() {
+    const condition = super.getCondition();
+    if (condition?.type !== 'expression') return condition;
+
+    const execute = condition.execute;
+    condition.execute = asyncExecute.bind(condition);
+
+    return condition;
+
+    function asyncExecute(message, callback) {
+      execute.call(condition, message, (executeErr, result) => {
+        if (executeErr) return callback(executeErr);
+        return Promise.resolve(result)
+          .then((r) => (callback ? callback(null, r) : result))
+          .catch((err) => (callback ? callback(err) : err));
+      });
+    }
+  }
+}
+
 Feature('Issue 39 - resolve SequenceFlow expression promise', () => {
   Scenario('expression function returns promise', () => {
     let context, definition, end;
@@ -58,24 +79,3 @@ Feature('Issue 39 - resolve SequenceFlow expression promise', () => {
     });
   });
 });
-
-class FlorianSequenceFlow extends SequenceFlow {
-  getCondition() {
-    const condition = super.getCondition();
-    if (condition?.type !== 'expression') return condition;
-
-    const execute = condition.execute;
-    condition.execute = asyncExecute.bind(condition);
-
-    return condition;
-
-    function asyncExecute(message, callback) {
-      execute.call(condition, message, (executeErr, result) => {
-        if (executeErr) return callback(executeErr);
-        return Promise.resolve(result)
-          .then((r) => (callback ? callback(null, r) : result))
-          .catch((err) => (callback ? callback(err) : err));
-      });
-    }
-  }
-}

test/flows/SequenceFlow-test.js

@@ -12,6 +12,46 @@ const extensions = {
 
 const multipleInboundSource = factory.resource('multiple-multiple-inbound.bpmn').toString();
 
+class TestScripts {
+  constructor() {
+    this.javaScripts = new Scripts();
+    this.scripts = new Map();
+  }
+  register({ id, type, behaviour }) {
+    if (!behaviour.conditionExpression) return;
+
+    const scriptBody = behaviour.conditionExpression.body;
+    const sync = !/next\(/.test(scriptBody);
+
+    const registered = this.javaScripts.register({
+      id,
+      type,
+      behaviour: {
+        conditionExpression: {
+          ...behaviour.conditionExpression,
+          language: 'javascript',
+        },
+      },
+    });
+
+    this.scripts.set(id, { sync, registered });
+  }
+  getScript(language, { id }) {
+    const { sync, registered } = this.scripts.get(id);
+    return {
+      execute,
+    };
+
+    function execute(executionContext, callback) {
+      if (sync) {
+        const result = registered.script.runInNewContext(executionContext);
+        return callback(null, result);
+      }
+      return registered.script.runInNewContext({ ...executionContext, next: callback });
+    }
+  }
+}
+
 describe('SequenceFlow', () => {
   describe('properties', () => {
     let context;
@@ -616,43 +656,3 @@ describe('SequenceFlow', () => {
     });
   });
 });
-
-class TestScripts {
-  constructor() {
-    this.javaScripts = new Scripts();
-    this.scripts = new Map();
-  }
-  register({ id, type, behaviour }) {
-    if (!behaviour.conditionExpression) return;
-
-    const scriptBody = behaviour.conditionExpression.body;
-    const sync = !/next\(/.test(scriptBody);
-
-    const registered = this.javaScripts.register({
-      id,
-      type,
-      behaviour: {
-        conditionExpression: {
-          ...behaviour.conditionExpression,
-          language: 'javascript',
-        },
-      },
-    });
-
-    this.scripts.set(id, { sync, registered });
-  }
-  getScript(language, { id }) {
-    const { sync, registered } = this.scripts.get(id);
-    return {
-      execute,
-    };
-
-    function execute(executionContext, callback) {
-      if (sync) {
-        const result = registered.script.runInNewContext(executionContext);
-        return callback(null, result);
-      }
-      return registered.script.runInNewContext({ ...executionContext, next: callback });
-    }
-  }
-}