refactor: [IOPLT-1964] collapsed Overlay component in LoadingSpinnerOverlay#8317
Open
LeleDallas wants to merge 2 commits into
Open
refactor: [IOPLT-1964] collapsed Overlay component in LoadingSpinnerOverlay#8317LeleDallas wants to merge 2 commits into
Overlay component in LoadingSpinnerOverlay#8317LeleDallas wants to merge 2 commits into
Conversation
LeleDallas
requested review from
a team,
Leerti,
emilio-dimari,
gispada and
soixdev91
as code owners
July 16, 2026 12:58
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8317 +/- ##
==========================================
- Coverage 62.92% 62.91% -0.01%
==========================================
Files 1963 1962 -1
Lines 37271 37265 -6
Branches 6290 6287 -3
==========================================
- Hits 23452 23446 -6
Misses 12436 12436
Partials 1383 1383
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This pull request refactors the overlay logic in the app by removing the deprecated
Overlaycomponent and inlining its behavior directly intoLoadingSpinnerOverlay. The change simplifies the codebase, consolidates overlay logic, and updates related tests and snapshots to reflect the new implementation.List of changes proposed in this pull request
Overlaycomponent and its tests, and moved overlay logic directly intoLoadingSpinnerOverlay, simplifying the component structureLoadingSpinnerOverlay.tsxto use internal styles and aView-based overlay instead of theOverlaycomponent, and improved overlay styling for better maintainabilityHow to test
LoadingSpinnerOverlayrender logic should be the same