feat: Add Credential Offer initial support#205
Draft
sebastianopriscan wants to merge 27 commits into
Draft
Conversation
Co-authored-by: LazyAfternoons <LazyAfternoons@users.noreply.github.com>
Co-authored-by: LazyAfternoons <LazyAfternoons@users.noreply.github.com>
…tation Co-authored-by: LazyAfternoons <LazyAfternoons@users.noreply.github.com>
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR solves WLS-123 by adding a first implementation for Credential Offer based issuance. While the flow is working, and credentials can be obtained, through offer QR Codes / Deeplinks, it doesn't fully comply to the ITW specification for the following reasons:
scopeandissuer_statefield in the credential offer's authorizationgrant are not forwarded to the PAR. (While the SDK partially supports it,io-react-native-walletdoes not, more on that later).authorization_serverfield isn't double checked against the issuer's Entity Configuration.Being that these issues are not blocking PARI integration PoC, I think that for the moment it would be better to wait for them to be patched in the original packages and then integrate them into the App, let me know if you agree.
List of changes proposed in this pull request
DeeplinkHandlerscreen that parses the URL and decides which flow to trigger (presentation or issuance).DeeplinkHandlerscreen process QR Code URLs, too.How to test
The tests from the following matrix have been performed successfully on both an Android Device and iOS Simulator.
Where the State fields mean the following:
The Has Cred column is related to the case in which the wallet already contains or not the credential in the offer / required for presentation. The presentation scenarios in which the Has Cred field is N/A could not be tested due to lacking a 1.3.3 aligned RP.
To test the QR Code credential offer, the following code can be used.
Depends on: #189 .