Skip to content

Add missing test cases for CI flow#153

Open
giovanni-riela wants to merge 1 commit into
mainfrom
feature/WLEO-1218-missing-ci-tests
Open

Add missing test cases for CI flow#153
giovanni-riela wants to merge 1 commit into
mainfrom
feature/WLEO-1218-missing-ci-tests

Conversation

@giovanni-riela
Copy link
Copy Markdown
Collaborator

Motivation and Context

The primary goal of this PR is to bridge the gap in test coverage for the issuance flow, specifically focusing on metadata validation, credential offer structure, and the security of wallet attestations. By adding these conformance tests, we ensure that the wallet implementation correctly handles both happy-path scenarios and various failure modes required by the technical specifications.

Key Changes:

  • Expanded Conformance Coverage (Issuance):
    • Metadata & Trust Validation: Added tests (CI_004, CI_005) to verify public key inclusion in Entity Configuration and Subordinate Statements and ensure the presence of Trust Marks.
    • Credential Offer Compliance: Implemented structure and parameter validation for Credential Offer URIs (CI_010, CI_012, CI_013), supporting both embedded and fetched offers.
    • Wallet Attestation Security: Introduced critical security checks (CI_031, CI_032, CI_033) for Pushed Authorization Requests (PAR), validating the rejection of tampered, expired, or improperly signed attestations.
    • Credential Integrity: Added CI_014 to verify the proper compilation of issued credentials using DCQL queries.

@giovanni-riela giovanni-riela requested a review from a team as a code owner May 21, 2026 09:52
@giovanni-riela giovanni-riela force-pushed the feature/WLEO-1218-missing-ci-tests branch from 5d23865 to 25f218c Compare May 22, 2026 10:15
@giovanni-riela giovanni-riela force-pushed the feature/WLEO-1218-missing-ci-tests branch from 25f218c to fc95125 Compare May 22, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant