Adding a Json provider in the same vein as the Xml provider.#465
Open
pagan-gerbil wants to merge 2 commits into
Open
Adding a Json provider in the same vein as the Xml provider.#465pagan-gerbil wants to merge 2 commits into
pagan-gerbil wants to merge 2 commits into
Conversation
Owner
|
Hello, thanks a lot for the PR. Could you make it against develop instead? |
paillave
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of Xml package reworked to read JSON files. Branched off of last nuget release to help this get published quickly if possible; only a minor change needed in JsonFileValuesProvider to make it compatible with the main branch HEAD.
Still want to add unit tests and an appropriate sample/documentation - if this is accepted I can justify the time to work on those.