BUG FIX: fixed search items (#5)

* fixed search items bug

* revert get item changes

Author: pajaydev

src/buy-api.js

@@ -6,15 +6,13 @@ const getItem = function (itemId) {
     const auth = "Bearer " + this.options.access_token;
     const id = encodeURIComponent(itemId);
     return makeRequest('api.ebay.com', `/buy/browse/v1/item/${id}`, 'GET', this.options.body, auth).then((result) => {
-        console.log("Success");
         let resultJSON = JSON.parse(result);
         //this.setAccessToken(resultJSON);
         return resultJSON;
     });
 };
 
 const getItemByLegacyId = function (legacyOptions) {
-    console.log(legacyOptions);
     if (!legacyOptions) throw new Error("Error Required input to get Items By LegacyID");
     if (!this.options.access_token) throw new Error("Missing Access token, Generate access token");
     if (!legacyOptions.legacyItemId) throw new Error("Error Legacy Item Id is required");
@@ -24,7 +22,6 @@ const getItemByLegacyId = function (legacyOptions) {
 
     makeRequest('api.ebay.com', `/buy/browse/v1/item/get_item_by_legacy_id?${param}`, 'GET', this.options.body, auth).then((result) => {
         let resultJSON = JSON.parse(result);
-        //this.setAccessToken(resultJSON);
         return resultJSON;
     }).then((error) => {
         console.log(error.errors);
@@ -39,28 +36,27 @@ const getItemByItemGroup = function (itemGroupId) {
     const auth = "Bearer " + this.options.access_token;
     return new Promise((resolve, reject) => {
         makeRequest('api.ebay.com', `/buy/browse/v1/item/get_items_by_item_group?item_group_id=${itemGroupId}`, 'GET', this.options.body, auth).then((result) => {
-            resolve(JSON.parse(result));
+            resolve(result);
         });
     })
 };
 
 const searchItems = function (searchConfig) {
-    console.log(searchConfig.keyword);
     if (!searchConfig) throw new Error("Error --> Missing or invalid input parameter to search");
     if (!searchConfig.keyword && !searchConfig.categoryId) throw new Error("Error --> Keyword or category id is required in query param");
     if (!this.options.access_token) throw new Error("Error -->Missing Access token, Generate access token");
-    if (searchConfig.fieldgroups.length > 0 && !Array.isArray(searchConfig.fieldgroups)) throw new Error("Error -->Field groups should be an array");
     const auth = "Bearer " + this.options.access_token;
-    let queryParam = searchConfig.keyword ? "q=" + searchConfig.keyword + "&" : "";
-    queryParam = queryParam + searchConfig.categoryId ? "category_ids=" + searchConfig.categoryId + "&" : '';
-    queryParam = queryParam + searchConfig.limit ? "limit=" + searchConfig.limit + "&" : "";
-    queryParam = queryParam + searchConfig.fieldgroups.length > 0 ? "fieldgroups=" + searchConfig.fieldgroups.toString() + "&" : "";
-    queryParam = queryParam + searchConfig.filter != undefined ? "filter=" + JSON.stringify(searchConfig.filter).replace(/[{}]/g, "") : "";
+    let queryParam = searchConfig.keyword ? "q=" + searchConfig.keyword : "";
+    queryParam = queryParam + (searchConfig.categoryId ? "&category_ids=" + searchConfig.categoryId : '');
+    queryParam = queryParam + (searchConfig.limit ? "&limit=" + searchConfig.limit : "");
+    if (searchConfig.fieldgroups != undefined) queryParam = queryParam + "&fieldgroups=" + searchConfig.fieldgroups.toString();
+    if (searchConfig.filter != undefined) queryParam = queryParam + "&filter=" + JSON.stringify(searchConfig.filter).replace(/[{}]/g, "");
+    console.log(queryParam);
     return new Promise((resolve, reject) => {
-        makeRequest('api.ebay.com', `buy/browse/v1/item_summary/search?${queryparam}`, 'GET', this.options.body, auth).then((result) => {
-            resolve(JSON.parse(result));
+        makeRequest('api.ebay.com', `/buy/browse/v1/item_summary/search?${queryParam}`, 'GET', this.options.body, auth).then((result) => {
+            resolve(result);
         });
-    })
+    });
 };
 
 module.exports = {