-
Notifications
You must be signed in to change notification settings - Fork 7
Allow the buildpack to skip #232
Copy link
Copy link
Open
Labels
hacktoberfestHacktoberfest eligibleHacktoberfest eligiblenote:ideal-for-contributionAn issue that a contributor can help us withAn issue that a contributor can help us withtype:enhancementA general enhancementA general enhancement
Metadata
Metadata
Assignees
Labels
hacktoberfestHacktoberfest eligibleHacktoberfest eligiblenote:ideal-for-contributionAn issue that a contributor can help us withAn issue that a contributor can help us withtype:enhancementA general enhancementA general enhancement
Type
Fields
Give feedbackNo fields configured for issues without a type.
Describe the Enhancement
In some cases, you may have an off-the-shelf WAR file that you are trying to deploy. It may contain a Main-Class entry for "reasons" and because it's off-the-shelf you cannot change that easily. In this scenario, the executable-jar buildpack will run first and see the Main-Class and incorrectly try to run it.
We should have a way to override the default behavior to tell executable-jar to skip.
Possible Solution
Add an env variable that disables the executable-jar buildpack, like
BP_EXECUTABLE_JAR_DISABLED. It would default to false. When true, it would just cause the buildpack to fail detection, which in turn would make it skip.Motivation
See Above.