Use recommended project.getService & update sinceBuild to match intellij version (#1295)

Use recommended project.getService & update sinceBuild to match intellij version

Author: crogoz

changelog/@unreleased/pr-1295.v2.yml

@@ -0,0 +1,6 @@
+type: fix
+fix:
+  description: Use recommended project.getService & update sinceBuild to match intellij
+    version
+  links:
+  - https://github.com/palantir/palantir-java-format/pull/1295

idea-plugin/build.gradle

@@ -27,7 +27,7 @@ intellij {
 
 patchPluginXml {
     pluginDescription = "Formats source code using the palantir-java-format tool."
-    sinceBuild = '213' // TODO: test against this version of IntelliJ to ensure no regressions
+    sinceBuild = '241' // TODO: keep the intellij version & sinceBuild in sync
     untilBuild = ''
 }
 

idea-plugin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatSettings.java

@@ -17,7 +17,6 @@
 package com.palantir.javaformat.intellij;
 
 import com.intellij.openapi.components.PersistentStateComponent;
-import com.intellij.openapi.components.ServiceManager;
 import com.intellij.openapi.components.State;
 import com.intellij.openapi.components.Storage;
 import com.intellij.openapi.project.Project;
@@ -43,7 +42,7 @@ public class PalantirJavaFormatSettings implements PersistentStateComponent<Pala
     private State state = new State();
 
     static PalantirJavaFormatSettings getInstance(Project project) {
-        return ServiceManager.getService(project, PalantirJavaFormatSettings.class);
+        return project.getService(PalantirJavaFormatSettings.class);
     }
 
     @SuppressWarnings("for-rollout:SameNameButDifferent")