fix: Fix phpstan issues and update pipeline actions to current versions (#324)

* fix: update property access methods to use instanceProperty since it has been deprecated

* Revert "fix: update property access methods to use instanceProperty since it has been deprecated"

This reverts commit 9541652.

* chore: since we need to support phpstan 1 lets baseline the deprecations

* chore: fix phpstan 1 analysis. Ignore a few deprecations

* chore: ignore ->file -> ->getFile() for now until we drop phpstan 1.

* build: small phpcs fixes

* build: update setup drupal action

* build: fixup php versions

* build: remove -vvv

Author: bbrala

.github/workflows/functional_test__rector_examples.yml

@@ -19,10 +19,10 @@ jobs:
             fail-fast: false
             matrix:
                 include:
-                    - php-version: "8.1"
+                    - php-version: "8.2"
                       drupal: "^10.0"
                       fixture: "d10"
-                    - php-version: "8.3"
+                    - php-version: "8.4"
                       drupal: "^10.0"
                       fixture: "d10"
         runs-on: ubuntu-latest
@@ -35,7 +35,7 @@ jobs:
                     tools: composer:v2
                     extensions: dom, curl, libxml, mbstring, zip, pdo, mysql, pdo_mysql, gd
             -   name: Setup Drupal
-                uses: bluehorndigital/setup-drupal@v1.0.4
+                uses: bluehorndigital/setup-drupal@v1.2.0
                 with:
                     version: '${{ matrix.drupal }}'
                     path: ~/drupal

.github/workflows/functional_test__single_rectors.yml

@@ -19,12 +19,12 @@ jobs:
             -   uses: actions/checkout@v3
             -   uses: shivammathur/setup-php@v2
                 with:
-                    php-version: "${{ matrix.php-version }}"
+                    php-version: "8.4"
                     coverage: none
                     tools: composer:v2
                     extensions: dom, curl, libxml, mbstring, zip, pdo, mysql, pdo_mysql, gd
             -   name: Setup Drupal
-                uses: bluehorndigital/setup-drupal@v1.0.4
+                uses: bluehorndigital/setup-drupal@v1.2.0
                 with:
                     version: '^11.0'
                     path: ~/drupal
@@ -47,7 +47,7 @@ jobs:
                         if [ -d "$d" ]; then
                             echo "Processing $d"
                             cp vendor/palantirnet/drupal-rector/tests/functional/$(basename ${d})/rector.php .
-                            vendor/bin/rector process $d -vvv --dry-run --debug || if (($? == 2)); then true; else exit 1; fi
+                            vendor/bin/rector process $d --dry-run --debug || if (($? == 2)); then true; else exit 1; fi
                         fi
                     done
             -   name: Run rector against Drupal

phpstan-1-baseline.neon

@@ -73,6 +73,14 @@ parameters:
 			count: 1
 			path: rector.php
 
+		-
+			message: """
+				#^Instantiation of deprecated class PhpParser\\\\Node\\\\Expr\\\\ArrayItem\\:
+				use \\\\PhpParser\\\\Node\\\\ArrayItem instead\\.$#
+			"""
+			count: 1
+			path: src/Drupal10/Rector/Deprecation/WatchdogExceptionRector.php
+
 		-
 			message: "#^Access to an undefined property PhpParser\\\\Node\\\\Expr\\:\\:\\$value\\.$#"
 			count: 2
@@ -143,7 +151,39 @@ parameters:
 			count: 1
 			path: src/Drupal8/Rector/Deprecation/FunctionalTestDefaultThemePropertyRector.php
 
+		-
+			message: """
+				#^Instantiation of deprecated class PhpParser\\\\Node\\\\Scalar\\\\Encapsed\\:
+				use \\\\PhpParser\\\\Node\\\\Scalar\\\\InterpolatedString instead\\.$#
+			"""
+			count: 1
+			path: src/Drupal9/Rector/Deprecation/AssertNoUniqueTextRector.php
+
+		-
+			message: """
+				#^Instantiation of deprecated class PhpParser\\\\Node\\\\Scalar\\\\EncapsedStringPart\\:
+				use \\\\PhpParser\\\\Node\\\\InterpolatedStringPart instead\\.$#
+			"""
+			count: 3
+			path: src/Drupal9/Rector/Deprecation/AssertNoUniqueTextRector.php
+
+		-
+			message: """
+				#^Instantiation of deprecated class PhpParser\\\\Node\\\\Scalar\\\\LNumber\\:
+				use \\\\PhpParser\\\\Node\\\\Scalar\\\\Int_ instead\\.$#
+			"""
+			count: 1
+			path: src/Drupal9/Rector/Deprecation/AssertNoUniqueTextRector.php
+
 		-
 			message: "#^Call to an undefined method PHPStan\\\\Type\\\\Type\\:\\:getValue\\(\\)\\.$#"
 			count: 1
 			path: src/Drupal9/Rector/Deprecation/ExtensionPathRector.php
+
+		-
+			message: """
+				#^Instantiation of deprecated class PhpParser\\\\Node\\\\Stmt\\\\UseUse\\:
+				use \\\\PhpParser\\\\Node\\\\UseItem instead\\.$#
+			"""
+			count: 1
+			path: src/Rector/Convert/HookConvertRector.php

phpstan-1.neon

@@ -4,8 +4,6 @@ parameters:
 		- config
 		- src
 		- rector.php
-	bootstrapFiles:
-	    - vendor/rector/rector/vendor/autoload.php
 	dynamicConstantNames:
 		- Drupal::VERSION
 includes: