Skip to content

disallow_untyped_calls#2895

Merged
ElLorans merged 1 commit into
masterfrom
chore/type_hints
May 21, 2026
Merged

disallow_untyped_calls#2895
ElLorans merged 1 commit into
masterfrom
chore/type_hints

Conversation

@ElLorans

@ElLorans ElLorans commented May 9, 2026

Copy link
Copy Markdown
Contributor

Set disallow_untyped_calls = true

Partially addresses #2440

Fix bug in contrib.mongoengine.QueryAjaxModelLoader.get_list: https://github.com/pallets-eco/flask-admin/pull/2895/changes#diff-b3160f646399a2e57029e9188abb71fc84434d25df401a7451346a3532f583d9R64
EDIT: the possible bug will be addressed in a separate PR

@ElLorans ElLorans force-pushed the chore/type_hints branch 8 times, most recently from a6c55a0 to cde0077 Compare May 10, 2026 17:24
@ElLorans ElLorans marked this pull request as ready for review May 10, 2026 17:51
@ElLorans ElLorans force-pushed the chore/type_hints branch 4 times, most recently from bb58312 to 37a3de6 Compare May 20, 2026 22:44
@ElLorans

ElLorans commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

@Bastian-Kuhn can you check if https://github.com/pallets-eco/flask-admin/pull/2895/changes#diff-b3160f646399a2e57029e9188abb71fc84434d25df401a7451346a3532f583d9R64 fixes a bug or not?
I will try to add a test and separate the PR

@ElLorans ElLorans force-pushed the chore/type_hints branch from 37a3de6 to 12568c2 Compare May 21, 2026 21:36
@ElLorans ElLorans merged commit cb31746 into master May 21, 2026
12 checks passed
@ElLorans ElLorans deleted the chore/type_hints branch May 21, 2026 21:39
ElLorans added a commit to mariofix/flask-admin that referenced this pull request May 23, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

1 participant