Extensible serializers support#326
Closed
NotoriousPyro wants to merge 17 commits into
Closed
Conversation
Revert "Add test_generic_get_bytes" Refs: 6ace510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #209 appears waiting on conflicts being merged, I thought I would work through the merge conflicts as I want to use this for a project. Unfortunately, what's stopping me is #209.
All the tests are passing. This is a merge of pallets-eco/master with subnix:feature/extensible-serializer and conflicts resolved.
Have also tested it with a working application. I have also debugged through and confirmed the serializer can be changed to JSON and also no longer accepts objects like "Response" (e.g. trying to apply the cache to a function which returns response.response) because they cannot be serialised to JSON.