tests: dispose engines in app fixture cleanup#1419
Open
krzysdz wants to merge 1 commit intopallets-eco:mainfrom
Open
tests: dispose engines in app fixture cleanup#1419krzysdz wants to merge 1 commit intopallets-eco:mainfrom
krzysdz wants to merge 1 commit intopallets-eco:mainfrom
Conversation
test_metadata.py::test_reflect requires manual engine disposal, because it overwrites `app.extensions["sqlalchemy"]`
Author
|
It looks like the "readthedocs" action is broken, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem described in #1379 is caused by a change to Python 3.13 introduced in python/cpython#105539. Calling
engine.dispose()makes SQLAlchemy close all connections from the pool used by engine.This PR fixes tests by adding cleanup to the
appfixture. Honestly, I don't know if this is only a problem with tests or if it can be somehow reproduced in a real use case.fixes #1379
closes #1380