bug fix select pagination for multi-column results#1424
Closed
hxzhao527 wants to merge 1 commit intopallets-eco:mainfrom
Closed
bug fix select pagination for multi-column results#1424hxzhao527 wants to merge 1 commit intopallets-eco:mainfrom
hxzhao527 wants to merge 1 commit intopallets-eco:mainfrom
Conversation
Return full result rows from SelectPagination instead of scalar values so paginated select queries preserve all selected columns.
hxzhao527
changed the title
Member
|
This breaks the much more common case of selecting a single model and getting back a list of instances instead of tuples. It needs to support both, which is the problem, since that's no longer possible to detect with public SQLAlchemy APIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return full result rows from SelectPagination instead of scalar values so paginated select queries preserve all selected columns.
fix #1423