Fix Path bytes dash check under Python bytes warnings

Author: Akshay Laddha

src/click/types.py

@@ -973,7 +973,13 @@ def convert(
     ) -> str | bytes | os.PathLike[str]:
         rv = value
 
-        is_dash = self.file_okay and self.allow_dash and rv in (b"-", "-")
+        if self.file_okay and self.allow_dash:
+            if isinstance(rv, bytes):
+                is_dash = rv == b"-"
+            else:
+                is_dash = rv == "-"
+        else:
+            is_dash = False
 
         if not is_dash:
             if self.resolve_path:

tests/test_types.py

@@ -1,6 +1,8 @@
 import os.path
 import pathlib
 import platform
+import subprocess
+import sys
 import tempfile
 
 import pytest
@@ -106,6 +108,23 @@ def test_path_type(runner, cls, expect):
     assert result.return_value == expect
 
 
+def test_path_bytes_dash_no_byteswarning():
+    result = subprocess.run(
+        [
+            sys.executable,
+            "-bb",
+            "-c",
+            "from click.types import Path; Path(allow_dash=True).convert(b'-', None, None)",
+        ],
+        cwd=pathlib.Path(__file__).resolve().parents[1],
+        env={**os.environ, "PYTHONPATH": "src"},
+        capture_output=True,
+        text=True,
+    )
+
+    assert result.returncode == 0, result.stderr
+
+
 def _symlinks_supported():
     with tempfile.TemporaryDirectory(prefix="click-pytest-") as tempdir:
         target = os.path.join(tempdir, "target")