Fixes flag default handling for boolean options#2912
Closed
john0isaac wants to merge 4 commits into
Closed
Conversation
Ensures boolean flag options correctly determine their default values when not explicitly set. Adds tests to validate proper behavior for various flag configurations, improving reliability. Fixes pallets#2897
john0isaac
commented
May 13, 2025
Contributor
Author
|
Although it's the same issue this won't fix #2894 as it's talking about Maybe we can revert the lines back but with Please let me know what you prefer. |
Member
|
Thanks for working on this. A contributor at the PyCon sprint ended up looking into this more and fixing it in a way we think is a little more correct in some cases, see #2930. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures boolean flag options correctly determine their default values when not explicitly set.
Adds tests to validate proper behavior for various flag configurations, improving reliability.
Fixes #2897