Expect alternate errors in test_file_surrogates()#2946
Merged
Conversation
ghost
force-pushed
the
file-system-assumption
branch
from
e8fa99d to
dce8a31
Compare
Collaborator
|
Thanks for the PR! Can use please add a comment that specifies the FileNotFoundError as the common case and the OsError as a special case for podman. |
Not all file systems trigger a FileNotFoundError when encountering surrogates. Inside Podman the file system triggers an `OSError: [Errno 84] Illegal byte sequence: '\udcff'`.
ghost
force-pushed
the
file-system-assumption
branch
from
dce8a31 to
7559bb8
Compare
Author
I tried a few filesystems that supposedly should not handle surrogates, but all of them work. Even overlayfs (which is used in podman), so the only explanation seems to be, that in rootless podman it passes through a user-space program (FUSE). Let me know if that comment is too detailed. |
Collaborator
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all file systems trigger a FileNotFoundError when encountering surrogates. Inside Podman the file system triggers an
OSError: [Errno 84] Illegal byte sequence: '\udcff'.fixes #2945