fix: _termui_impl.open_url() — 'start' on Windows is a cmd built-in, not an executable#3186
Open
karpierz wants to merge 1 commit intopallets:stablefrom
Open
fix: _termui_impl.open_url() — 'start' on Windows is a cmd built-in, not an executable#3186karpierz wants to merge 1 commit intopallets:stablefrom
_termui_impl.open_url() — 'start' on Windows is a cmd built-in, not an executable#3186karpierz wants to merge 1 commit intopallets:stablefrom
Conversation
kdeldycke
changed the title
_termui_impl.open_url() — 'start' on Windows is a cmd built-in, not an executable
kdeldycke
added
bug
windows
Collaborator
|
|
Collaborator
|
OK got it. Click code is broken on Windows because But there is a better fix. Instead of re-introducing |
Closes pallets#3164 Co-Authored-By: Adam Karpierz <akarpierz@gmail.com>
kdeldycke
force-pushed
the
fixes_for_windows
branch
from
8069bb9 to
d04d367
Compare
Collaborator
|
I just re-implemented the fix. This PR is ready to be merged in the next devlopment cycle of Click. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: _termui_impl.open_url() — 'start' on Windows is a cmd built-in command, not an executable