fix: handle spaces in paths for launch(locate=True) on Windows#3341
Closed
Herrtian wants to merge 1 commit into
Closed
fix: handle spaces in paths for launch(locate=True) on Windows#3341Herrtian wants to merge 1 commit into
Herrtian wants to merge 1 commit into
Conversation
explorer /select,<path> was passed as a list to subprocess.call(), which caused Windows to split the path at spaces. Changed to pass a single command string with the path quoted so explorer receives the full path correctly. Fixes #2994
Collaborator
|
AI slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2994
On Windows,
launch(path, locate=True)passes the explorer command as a list:subprocess.calljoins list args with spaces, so a path likeC:\my folder\file.txtgets split at the space and explorer opens the wrong location.Changed to pass a single string with the path quoted so it works with spaces.