Fix: show full option name in error for unknown multi-char short options#3395
Closed
afsar-hussai wants to merge 1 commit intopallets:mainfrom
Closed
Fix: show full option name in error for unknown multi-char short options#3395afsar-hussai wants to merge 1 commit intopallets:mainfrom
afsar-hussai wants to merge 1 commit intopallets:mainfrom
Conversation
… multichar short opts When an unknown multi-character short option like `-dbg` was passed, the error message incorrectly showed only the first character: "No such option: -d." This change passes the full original argument to NoSuchOption so the message correctly shows "No such option: -dbg." Fixes pallets#2779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an unknown multi-character short option like
-dbgis passed, click shows "No such option: -d" instead of "No such option:-dbg". Only the first character was shown, which is misleading.
Fixed by passing the full original argument to
NoSuchOptionin_match_short_optinstead of the single-characteropt.Added a test
test_unknown_multichar_short_option_shows_full_nameto verify the fix.fixes #2779