Fix HelpFormatter.write_usage dropping prefix when args is empty#3415
Closed
bibekmhj wants to merge 1 commit intopallets:mainfrom
Closed
Fix HelpFormatter.write_usage dropping prefix when args is empty#3415bibekmhj wants to merge 1 commit intopallets:mainfrom
bibekmhj wants to merge 1 commit intopallets:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3360.
Tracked this down — when
args=""the function callswrap_text("", ..., initial_indent=usage_prefix, ...), buttextwrap.fillof an empty string returns""without emitting theinitial_indent. So the"Usage: program "prefix gets dropped on the floor and only the trailing newline makes it through. Empty line, just like the issue.So the fix just writes the prefix directly when there are no args, and only goes through
wrap_textwhen there's something to wrap. The else-branch (prefix too long) doesn't hit this because it already writesusage_prefixbefore the wrap call.Added a regression test using the reporter's repro.