Fix parsing when a parameter is named help#3678
Conversation
44f9b05 to
bb8244c
Compare
775a1cf to
ee8a410
Compare
|
Perhaps we could just always force an internal name, like |
|
I think that is probably best. |
Yeah why not! Need to check if there is a nasty case in which a user can create its own argument or option that get assigned this internal ID. 😈 Wait. Hold on to that PR. I might have found that this issue not only affects |
Fix parsing when a parameter is named `help`, closing pallets#2819
ee8a410 to
3495fba
Compare
|
I just changed the strategy to always naming Click's own The only compromise: the public |
This PR fixes #2819 by having ou pre-configured
--helpparameter automatically change its internal name used to store its value, in the case of a user providing its own argument or option conflicting with ours.Note that I arbitrarily used a convention of adding underscores
_to that internal name until no other parameter conflict with it. I'm ready to change that strategy if it is does not look good.